2019-06-27 07:01:47

by Masahiro Yamada

Subject: [PATCH] xtensa: remove unneeded BITS_PER_LONG define

Xtensa does not define CONFIG_64BIT. The generic definition in
include/asm-generic/bitsperlong.h should work.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/xtensa/include/asm/types.h | 8 --------
1 file changed, 8 deletions(-)

diff --git a/arch/xtensa/include/asm/types.h b/arch/xtensa/include/asm/types.h
index 2b410b8c7f79..44f411c75837 100644
--- a/arch/xtensa/include/asm/types.h
+++ b/arch/xtensa/include/asm/types.h
@@ -12,12 +12,4 @@

#include <uapi/asm/types.h>

-#ifndef __ASSEMBLY__
-/*
- * These aren't exported outside the kernel to avoid name space clashes
- */
-
-#define BITS_PER_LONG 32
-
-#endif
#endif /* _XTENSA_TYPES_H */
--
2.17.1

2019-06-27 20:38:20

by Max Filippov

Subject: Re: [PATCH] xtensa: remove unneeded BITS_PER_LONG define

Hi Yamada-san,

On Thu, Jun 27, 2019 at 12:01 AM Masahiro Yamada
<[email protected]> wrote:
>
> Xtensa does not define CONFIG_64BIT. The generic definition in
> include/asm-generic/bitsperlong.h should work.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/xtensa/include/asm/types.h | 8 --------
> 1 file changed, 8 deletions(-)

After this change the file arch/xtensa/include/asm/types.h is effectively
empty, only including uapi/asm/types.h. Maybe it should be dropped
altogether?

--
Thanks.
-- Max