2019-07-15 11:44:55

by Fuqian Huang

Subject: [PATCH] drm/amd/powerplay: remove redundant memset

kzalloc has already zeroed the memory.
So the memset is unneeded.

Signed-off-by: Fuqian Huang <[email protected]>
---
drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
index 8fafcbdb1dfd..0fb6066997b2 100644
--- a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
@@ -1295,7 +1295,6 @@ static int vega20_set_default_od8_setttings(struct smu_context *smu)
if (!table_context->od8_settings)
return -ENOMEM;

- memset(table_context->od8_settings, 0, sizeof(struct vega20_od8_settings));
od8_settings = (struct vega20_od8_settings *)table_context->od8_settings;

if (smu_feature_is_enabled(smu, FEATURE_DPM_SOCCLK_BIT)) {
--
2.11.0

2019-07-15 13:23:10

by Markus Elfring

Subject: Re: drm/amd/powerplay: remove redundant memset

> kzalloc has already zeroed the memory.
> So the memset is unneeded.

See also a previous patch:
drm/amd/powerplay: Delete a redundant memory setting in vega20_set_default_od8_setttings()
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/patchwork/patch/1089691/
https://lkml.org/lkml/2019/6/17/460

Regards,
Markus