2019-07-23 15:42:23

by Bartosz Golaszewski

Subject: Re: [PATCH v2] gpio: pch: Use dev_get_drvdata

wt., 23 lip 2019 o 10:39 Chuhong Yuan <[email protected]> napisał(a):
>
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
>
> Signed-off-by: Chuhong Yuan <[email protected]>
> ---
> Changes in v2:
> - Change the subject line to gpio: pch: ...
>
> drivers/gpio/gpio-pch.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> index 1d99293096f2..3f3d9a94b709 100644
> --- a/drivers/gpio/gpio-pch.c
> +++ b/drivers/gpio/gpio-pch.c
> @@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,
>
> static int __maybe_unused pch_gpio_suspend(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct pch_gpio *chip = pci_get_drvdata(pdev);
> + struct pch_gpio *chip = dev_get_drvdata(dev);
> unsigned long flags;
>
> spin_lock_irqsave(&chip->spinlock, flags);
> @@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev)
>
> static int __maybe_unused pch_gpio_resume(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct pch_gpio *chip = pci_get_drvdata(pdev);
> + struct pch_gpio *chip = dev_get_drvdata(dev);
> unsigned long flags;
>
> spin_lock_irqsave(&chip->spinlock, flags);
> --
> 2.20.1
>

Acked-by: Bartosz Golaszewski <[email protected]>

2019-07-24 01:06:22

by Andy Shevchenko

Subject: Re: [PATCH v2] gpio: pch: Use dev_get_drvdata

On Tue, Jul 23, 2019 at 11:49:46AM +0200, Bartosz Golaszewski wrote:
> wt., 23 lip 2019 o 10:39 Chuhong Yuan <[email protected]> napisał(a):
> >
> > Instead of using to_pci_dev + pci_get_drvdata,
> > use dev_get_drvdata to make code simpler.
> >
> > Signed-off-by: Chuhong Yuan <[email protected]>
> > ---
> > Changes in v2:
> > - Change the subject line to gpio: pch: ...
> >
> > drivers/gpio/gpio-pch.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> > index 1d99293096f2..3f3d9a94b709 100644
> > --- a/drivers/gpio/gpio-pch.c
> > +++ b/drivers/gpio/gpio-pch.c
> > @@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,
> >
> > static int __maybe_unused pch_gpio_suspend(struct device *dev)
> > {
> > - struct pci_dev *pdev = to_pci_dev(dev);
> > - struct pch_gpio *chip = pci_get_drvdata(pdev);
> > + struct pch_gpio *chip = dev_get_drvdata(dev);
> > unsigned long flags;
> >
> > spin_lock_irqsave(&chip->spinlock, flags);
> > @@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev)
> >
> > static int __maybe_unused pch_gpio_resume(struct device *dev)
> > {
> > - struct pci_dev *pdev = to_pci_dev(dev);
> > - struct pch_gpio *chip = pci_get_drvdata(pdev);
> > + struct pch_gpio *chip = dev_get_drvdata(dev);
> > unsigned long flags;
> >
> > spin_lock_irqsave(&chip->spinlock, flags);
> > --
> > 2.20.1
> >
>
> Acked-by: Bartosz Golaszewski <[email protected]>

Pushed to my review and testing queue, thanks!


--
With Best Regards,
Andy Shevchenko