2019-07-28 23:04:11

by Matteo Croce

Subject: [PATCH] arm64: mark expected switch fall-through

Move the "fallthrough" comment just because the case keyword,
fixes the following warning:

In file included from ./include/linux/kernel.h:15,
from ./include/linux/list.h:9,
from ./include/linux/kobject.h:19,
from ./include/linux/of.h:17,
from ./include/linux/irqdomain.h:35,
from ./include/linux/acpi.h:13,
from arch/arm64/kernel/smp.c:9:
arch/arm64/kernel/smp.c: In function ‘__cpu_up’:
./include/linux/printk.h:302:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/smp.c:156:4: note: in expansion of macro ‘pr_crit’
pr_crit("CPU%u: may not have shut down cleanly\n", cpu);
^~~~~~~
arch/arm64/kernel/smp.c:157:3: note: here
case CPU_STUCK_IN_KERNEL:
^~~~

Signed-off-by: Matteo Croce <[email protected]>
---
arch/arm64/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index ea90d3bd9253..018a33e01b0e 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -152,8 +152,8 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
pr_crit("CPU%u: died during early boot\n", cpu);
break;
}
- /* Fall through */
pr_crit("CPU%u: may not have shut down cleanly\n", cpu);
+ /* Fall through */
case CPU_STUCK_IN_KERNEL:
pr_crit("CPU%u: is stuck in kernel\n", cpu);
if (status & CPU_STUCK_REASON_52_BIT_VA)
--
2.21.0

2019-07-29 10:02:41

by Will Deacon

Subject: Re: [PATCH] arm64: mark expected switch fall-through

On Mon, Jul 29, 2019 at 01:03:10AM +0200, Matteo Croce wrote:
> Move the "fallthrough" comment just because the case keyword,
> fixes the following warning:
>
> In file included from ./include/linux/kernel.h:15,
> from ./include/linux/list.h:9,
> from ./include/linux/kobject.h:19,
> from ./include/linux/of.h:17,
> from ./include/linux/irqdomain.h:35,
> from ./include/linux/acpi.h:13,
> from arch/arm64/kernel/smp.c:9:
> arch/arm64/kernel/smp.c: In function ‘__cpu_up’:
> ./include/linux/printk.h:302:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
> printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> arch/arm64/kernel/smp.c:156:4: note: in expansion of macro ‘pr_crit’
> pr_crit("CPU%u: may not have shut down cleanly\n", cpu);
> ^~~~~~~
> arch/arm64/kernel/smp.c:157:3: note: here
> case CPU_STUCK_IN_KERNEL:
> ^~~~
>
> Signed-off-by: Matteo Croce <[email protected]>
> ---
> arch/arm64/kernel/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Already fixed via [1]. Please can you people work together?

Will

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-July/668934.html