2019-07-30 04:30:22

by Deepa Dinamani

Subject: [PATCH 18/20] fs: omfs: Initialize filesystem timestamp ranges

Fill in the appropriate limits to avoid inconsistencies
in the vfs cached inode times when timestamps are
outside the permitted range.

Signed-off-by: Deepa Dinamani <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
fs/omfs/inode.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index 08226a835ec3..b76ec6b88ded 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -478,6 +478,10 @@ static int omfs_fill_super(struct super_block *sb, void *data, int silent)

sb->s_maxbytes = 0xffffffff;

+ sb->s_time_gran = NSEC_PER_MSEC;
+ sb->s_time_min = 0;
+ sb->s_time_max = U64_MAX / MSEC_PER_SEC;
+
sb_set_blocksize(sb, 0x200);

bh = sb_bread(sb, 0);
--
2.17.1

2019-07-30 16:36:10

by Bob Copeland

Subject: Re: [PATCH 18/20] fs: omfs: Initialize filesystem timestamp ranges

On Mon, Jul 29, 2019 at 06:49:22PM -0700, Deepa Dinamani wrote:
> Fill in the appropriate limits to avoid inconsistencies
> in the vfs cached inode times when timestamps are
> outside the permitted range.
>
> Signed-off-by: Deepa Dinamani <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> fs/omfs/inode.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
> index 08226a835ec3..b76ec6b88ded 100644
> --- a/fs/omfs/inode.c
> +++ b/fs/omfs/inode.c
> @@ -478,6 +478,10 @@ static int omfs_fill_super(struct super_block *sb, void *data, int silent)
>
> sb->s_maxbytes = 0xffffffff;
>
> + sb->s_time_gran = NSEC_PER_MSEC;
> + sb->s_time_min = 0;
> + sb->s_time_max = U64_MAX / MSEC_PER_SEC;
> +

I honestly don't know if it should be s64 rather than u64, but considering
that none of the devices with this filesystem ever exposed dates to users in
the negative era, it should be fine.

Acked-by: Bob Copeland <[email protected]>

--
Bob Copeland %% https://bobcopeland.com/