2019-07-31 11:04:41

by Ding Xiang

Subject: [PATCH] gpio: ixp4xx: remove redundant dev_err message

devm_ioremap_resource already contains error message, so remove
the redundant dev_err message

Signed-off-by: Ding Xiang <[email protected]>
---
drivers/gpio/gpio-ixp4xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
index 670c2a8..2b2b89b 100644
--- a/drivers/gpio/gpio-ixp4xx.c
+++ b/drivers/gpio/gpio-ixp4xx.c
@@ -321,10 +321,8 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
g->base = devm_ioremap_resource(dev, res);
- if (IS_ERR(g->base)) {
- dev_err(dev, "ioremap error\n");
+ if (IS_ERR(g->base))
return PTR_ERR(g->base);
- }

/*
* Make sure GPIO 14 and 15 are NOT used as clocks but GPIO on
--
1.9.1

2019-07-31 11:14:05

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: ixp4xx: remove redundant dev_err message

śr., 31 lip 2019 o 11:48 Ding Xiang <[email protected]> napisał(a):
>
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
>
> Signed-off-by: Ding Xiang <[email protected]>
> ---
> drivers/gpio/gpio-ixp4xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
> index 670c2a8..2b2b89b 100644
> --- a/drivers/gpio/gpio-ixp4xx.c
> +++ b/drivers/gpio/gpio-ixp4xx.c
> @@ -321,10 +321,8 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> g->base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(g->base)) {
> - dev_err(dev, "ioremap error\n");
> + if (IS_ERR(g->base))
> return PTR_ERR(g->base);
> - }
>
> /*
> * Make sure GPIO 14 and 15 are NOT used as clocks but GPIO on
> --
> 1.9.1
>
>
>

Patch applied, thanks!

Bart