2005-12-10 05:40:23

by Dave Jones

[permalink] [raw]
Subject: broken cast in parport_pc

Spotted by a Fedora user. Compiling with DEBUG_PARPORT set fails
due to the broken cast.

Just remove it.

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6.14/include/linux/parport_pc.h~ 2005-12-10 00:26:42.000000000 -0500
+++ linux-2.6.14/include/linux/parport_pc.h 2005-12-10 00:38:57.000000000 -0500
@@ -86,7 +86,7 @@ extern __inline__ void dump_parport_stat
unsigned char dcr = inb (CONTROL (p));
unsigned char dsr = inb (STATUS (p));
static char *ecr_modes[] = {"SPP", "PS2", "PPFIFO", "ECP", "xXx", "yYy", "TST", "CFG"};
- const struct parport_pc_private *priv = (parport_pc_private *)p->physport->private_data;
+ const struct parport_pc_private *priv = p->physport->private_data;
int i;

printk (KERN_DEBUG "*** parport state (%s): ecr=[%s", str, ecr_modes[(ecr & 0xe0) >> 5]);