2019-08-21 21:00:39

by Masahiro Yamada

Subject: [PATCH] kbuild: remove unneeded dependency for $(DOC_TARGETS)

Commit 415008af3219 ("docs-rst: convert lsm from DocBook to ReST")
stopped using if_changed_rule. No more users of if_changed* for the
doc targets. Hence, fixdep is unneeded. Remove the dependency on
scripts_basic.

All the doc targets are phony. Depending on FORCE is odd.

Signed-off-by: Masahiro Yamada <[email protected]>
---

Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index c0be1a4dbfdd..7e54a821b4b0 100644
--- a/Makefile
+++ b/Makefile
@@ -1578,7 +1578,7 @@ $(help-board-dirs): help-%:
DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs \
linkcheckdocs dochelp refcheckdocs
PHONY += $(DOC_TARGETS)
-$(DOC_TARGETS): scripts_basic FORCE
+$(DOC_TARGETS):
$(Q)$(MAKE) $(build)=Documentation $@

# Misc
--
2.17.1

2019-08-28 16:45:18

by Masahiro Yamada

Subject: Re: [PATCH] kbuild: remove unneeded dependency for $(DOC_TARGETS)

On Thu, Aug 22, 2019 at 2:33 AM Masahiro Yamada
<[email protected]> wrote:
>
> Commit 415008af3219 ("docs-rst: convert lsm from DocBook to ReST")
> stopped using if_changed_rule. No more users of if_changed* for the
> doc targets. Hence, fixdep is unneeded. Remove the dependency on
> scripts_basic.
>
> All the doc targets are phony. Depending on FORCE is odd.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---

Applied to linux-kbuild.


> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c0be1a4dbfdd..7e54a821b4b0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1578,7 +1578,7 @@ $(help-board-dirs): help-%:
> DOC_TARGETS := xmldocs latexdocs pdfdocs htmldocs epubdocs cleandocs \
> linkcheckdocs dochelp refcheckdocs
> PHONY += $(DOC_TARGETS)
> -$(DOC_TARGETS): scripts_basic FORCE
> +$(DOC_TARGETS):
> $(Q)$(MAKE) $(build)=Documentation $@
>
> # Misc
> --
> 2.17.1
>


--
Best Regards
Masahiro Yamada