The kbuild bot reported the following compiler errors when compiling on
MIPS with CONFIG_QCOM_OCMEM disabled:
In file included from <command-line>:0:0:
>> include/soc/qcom/ocmem.h:43:49: warning: 'struct device' declared
inside parameter list will not be visible outside of this
definition or declaration
static inline struct ocmem *of_get_ocmem(struct device *dev)
^~~~~~
include/soc/qcom/ocmem.h: In function 'of_get_ocmem':
>> include/soc/qcom/ocmem.h:45:9: error: implicit declaration of
function 'ERR_PTR' [-Werror=implicit-function-declaration]
return ERR_PTR(-ENODEV);
^~~~~~~
>> include/soc/qcom/ocmem.h:45:18: error: 'ENODEV' undeclared (first
use in this function)
return ERR_PTR(-ENODEV);
Add the proper includes to fix the compiler errors.
Signed-off-by: Brian Masney <[email protected]>
Reported-by: kbuild test robot <[email protected]>
---
My OCMEM series [1] hasn't landed upstream yet so let me know if you
want me to squash this into the existing patch set. I made this a
separate patch so that the Reported-by could be included. The kbuild
report is at [2].
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lists.01.org/pipermail/kbuild-all/2019-August/063530.html
include/soc/qcom/ocmem.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/soc/qcom/ocmem.h b/include/soc/qcom/ocmem.h
index a0ae336ba78b..02a8bc2677b1 100644
--- a/include/soc/qcom/ocmem.h
+++ b/include/soc/qcom/ocmem.h
@@ -9,6 +9,9 @@
* Copyright (C) 2015 Red Hat. Author: Rob Clark <[email protected]>
*/
+#include <linux/device.h>
+#include <linux/err.h>
+
#ifndef __OCMEM_H__
#define __OCMEM_H__
--
2.21.0
On Sun 01 Sep 14:30 PDT 2019, Brian Masney wrote:
> The kbuild bot reported the following compiler errors when compiling on
> MIPS with CONFIG_QCOM_OCMEM disabled:
>
> In file included from <command-line>:0:0:
> >> include/soc/qcom/ocmem.h:43:49: warning: 'struct device' declared
> inside parameter list will not be visible outside of this
> definition or declaration
> static inline struct ocmem *of_get_ocmem(struct device *dev)
> ^~~~~~
> include/soc/qcom/ocmem.h: In function 'of_get_ocmem':
> >> include/soc/qcom/ocmem.h:45:9: error: implicit declaration of
> function 'ERR_PTR' [-Werror=implicit-function-declaration]
> return ERR_PTR(-ENODEV);
> ^~~~~~~
> >> include/soc/qcom/ocmem.h:45:18: error: 'ENODEV' undeclared (first
> use in this function)
> return ERR_PTR(-ENODEV);
>
> Add the proper includes to fix the compiler errors.
>
> Signed-off-by: Brian Masney <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
> ---
> My OCMEM series [1] hasn't landed upstream yet so let me know if you
> want me to squash this into the existing patch set. I made this a
> separate patch so that the Reported-by could be included. The kbuild
> report is at [2].
>
> [1] https://lore.kernel.org/lkml/[email protected]/
> [2] https://lists.01.org/pipermail/kbuild-all/2019-August/063530.html
>
> include/soc/qcom/ocmem.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/soc/qcom/ocmem.h b/include/soc/qcom/ocmem.h
> index a0ae336ba78b..02a8bc2677b1 100644
> --- a/include/soc/qcom/ocmem.h
> +++ b/include/soc/qcom/ocmem.h
> @@ -9,6 +9,9 @@
> * Copyright (C) 2015 Red Hat. Author: Rob Clark <[email protected]>
> */
>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +
> #ifndef __OCMEM_H__
> #define __OCMEM_H__
>
> --
> 2.21.0
>