A bunch of cleanups and fixes for issues found while working with the
code. Changes are individual and independent from each other. They can
be applied separately (only #4 depends on #3).
Also updating the reviewer's entry as I will be able to do some
reviews for edac code.
Note that patch #3 is an updated version of a patch reviewed before:
https://lore.kernel.org/patchwork/patch/1093466/
Some references to ml discussions that are related to this series:
https://lore.kernel.org/patchwork/patch/1093480/#1312590
https://lore.kernel.org/patchwork/patch/1093466/#1310572
Robert Richter (5):
EDAC: Prefer 'unsigned int' to bare use of 'unsigned'
EDAC, mc_sysfs: Change dev_ch_attribute->channel to unsigned int
EDAC, mc_sysfs: Remove pointless gotos
EDAC, mc_sysfs: Make debug messages consistent
MAINTAINERS: update EDAC's reviewer entry
MAINTAINERS | 1 +
drivers/edac/edac_mc.c | 20 ++++----
drivers/edac/edac_mc.h | 6 +--
drivers/edac/edac_mc_sysfs.c | 91 ++++++++++++++++--------------------
drivers/edac/ghes_edac.c | 2 +-
drivers/edac/i5100_edac.c | 16 ++++---
include/linux/edac.h | 10 ++--
7 files changed, 69 insertions(+), 77 deletions(-)
--
2.20.1
I did some significant work with code in edac_mc.c and ghes_edac.c
already, so I guess I can probably helping out a bit as code reviewer
here.
Signed-off-by: Robert Richter <[email protected]>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 97912d8333a9..79d2ae8519e3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5788,6 +5788,7 @@ M: Borislav Petkov <[email protected]>
M: Mauro Carvalho Chehab <[email protected]>
M: Tony Luck <[email protected]>
R: James Morse <[email protected]>
+R: Robert Richter <[email protected]>
L: [email protected]
T: git git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next
S: Supported
--
2.20.1
Em Mon, 2 Sep 2019 12:33:38 +0000
Robert Richter <[email protected]> escreveu:
> A bunch of cleanups and fixes for issues found while working with the
> code. Changes are individual and independent from each other. They can
> be applied separately (only #4 depends on #3).
>
> Also updating the reviewer's entry as I will be able to do some
> reviews for edac code.
>
> Note that patch #3 is an updated version of a patch reviewed before:
>
> https://lore.kernel.org/patchwork/patch/1093466/
>
> Some references to ml discussions that are related to this series:
>
> https://lore.kernel.org/patchwork/patch/1093480/#1312590
> https://lore.kernel.org/patchwork/patch/1093466/#1310572
>
> Robert Richter (5):
> EDAC: Prefer 'unsigned int' to bare use of 'unsigned'
> EDAC, mc_sysfs: Change dev_ch_attribute->channel to unsigned int
> EDAC, mc_sysfs: Remove pointless gotos
> EDAC, mc_sysfs: Make debug messages consistent
> MAINTAINERS: update EDAC's reviewer entry
For the entire series:
Reviewed-by: Mauro Carvalho Chehab <[email protected]>
>
> MAINTAINERS | 1 +
> drivers/edac/edac_mc.c | 20 ++++----
> drivers/edac/edac_mc.h | 6 +--
> drivers/edac/edac_mc_sysfs.c | 91 ++++++++++++++++--------------------
> drivers/edac/ghes_edac.c | 2 +-
> drivers/edac/i5100_edac.c | 16 ++++---
> include/linux/edac.h | 10 ++--
> 7 files changed, 69 insertions(+), 77 deletions(-)
>
Thanks,
Mauro
On Mon, Sep 02, 2019 at 05:17:16PM -0300, Mauro Carvalho Chehab wrote:
> > Robert Richter (5):
> > EDAC: Prefer 'unsigned int' to bare use of 'unsigned'
> > EDAC, mc_sysfs: Change dev_ch_attribute->channel to unsigned int
> > EDAC, mc_sysfs: Remove pointless gotos
> > EDAC, mc_sysfs: Make debug messages consistent
> > MAINTAINERS: update EDAC's reviewer entry
>
> For the entire series:
>
> Reviewed-by: Mauro Carvalho Chehab <[email protected]>
>
> >
> > MAINTAINERS | 1 +
> > drivers/edac/edac_mc.c | 20 ++++----
> > drivers/edac/edac_mc.h | 6 +--
> > drivers/edac/edac_mc_sysfs.c | 91 ++++++++++++++++--------------------
> > drivers/edac/ghes_edac.c | 2 +-
> > drivers/edac/i5100_edac.c | 16 ++++---
> > include/linux/edac.h | 10 ++--
> > 7 files changed, 69 insertions(+), 77 deletions(-)
Queued, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette