2019-09-13 19:17:48

by Saiyam Doshi

Subject: [PATCH] omfs: make use of kmemdup

Replace call to kmalloc followed by memcpy with a direct call
to kmemdup to achieve same functionality.

Signed-off-by: Saiyam Doshi <[email protected]>
---
fs/omfs/inode.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index b76ec6b88ded..788b41096962 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -363,12 +363,13 @@ static int omfs_get_imap(struct super_block *sb)
bh = sb_bread(sb, block++);
if (!bh)
goto nomem_free;
- *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
+
+ *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
if (!*ptr) {
brelse(bh);
goto nomem_free;
}
- memcpy(*ptr, bh->b_data, sb->s_blocksize);
+
if (count < sb->s_blocksize)
memset((void *)*ptr + count, 0xff,
sb->s_blocksize - count);
--
2.20.1

2019-09-14 15:06:33

by Markus Elfring

Subject: Re: omfs: make use of kmemdup

> Replace call to kmalloc followed by memcpy with a direct call
> to kmemdup to achieve same functionality.

I suggest to take another look at a similar patch.

fs/omfs: make use of kmemdup
https://lore.kernel.org/r/20190721112326.GA5927@hari-Inspiron-1545/
https://lore.kernel.org/patchwork/patch/1102482/
https://lkml.org/lkml/2019/7/21/40

Regards,
Markus

2019-09-16 21:39:31

by Saiyam Doshi

Subject: Re: omfs: make use of kmemdup

On Sat, Sep 14, 2019 at 08:24:37AM +0200, Markus Elfring wrote:
> I suggest to take another look at a similar patch.
>
> fs/omfs: make use of kmemdup
> https://lore.kernel.org/r/20190721112326.GA5927@hari-Inspiron-1545/
> https://lore.kernel.org/patchwork/patch/1102482/
> https://lkml.org/lkml/2019/7/21/40

Oh I missed that. The patch you pointed above is of July, 2019 but I am
not seeing it in v5.3 or in next-20190915.

If you know, can you point to the fs/omfs tree. It will help not to send
repeated change.

-Saiyam