2019-09-18 22:34:12

by Arnd Bergmann

Subject: [PATCH] ahci: stop exporting ahci_em_messages

The symbol is now static and not used elswhere, which
leads to a warning message:

WARNING: "ahci_em_messages" [vmlinux] is a static EXPORT_SYMBOL_GPL

Fixes: ed08d40cdec4 ("ahci: Changing two module params with static and __read_mostly")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/ata/libahci.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index e4c45d3cca79..bff369d9a1a7 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -175,7 +175,6 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {
EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);

static bool ahci_em_messages __read_mostly = true;
-EXPORT_SYMBOL_GPL(ahci_em_messages);
module_param(ahci_em_messages, bool, 0444);
/* add other LED protocol types when they become supported */
MODULE_PARM_DESC(ahci_em_messages,
--
2.20.0

2019-09-19 00:57:16

by Jens Axboe

Subject: Re: [PATCH] ahci: stop exporting ahci_em_messages

On 9/18/19 2:00 PM, Arnd Bergmann wrote:
> The symbol is now static and not used elswhere, which
> leads to a warning message:
>
> WARNING: "ahci_em_messages" [vmlinux] is a static EXPORT_SYMBOL_GPL

If you look at master, this was fixed in this merge window:

commit 60fc35f327e0a9e60b955c0f3c3ed623608d1baa
Author: Andy Shevchenko <[email protected]>
Date: Fri Aug 30 22:42:55 2019 +0300

ahci: Do not export local variable ahci_em_messages

--
Jens Axboe