to_mp() was first introduced with the following commit:
'commit 801cc4e17a34c ("xfs: debug mode forced buffered write failure")'
But the user of to_mp() was removed by below commit:
'commit f8c47250ba46e ("xfs: convert drop_writes to use the errortag
mechanism")'
So kernel build with clang throws below warning message:
fs/xfs/xfs_sysfs.c:72:1: warning: unused function 'to_mp' [-Wunused-function]
to_mp(struct kobject *kobject)
Hence to_mp() might be removed safely to get rid of warning message.
Signed-off-by: Austin Kim <[email protected]>
---
fs/xfs/xfs_sysfs.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c
index ddd0bf7..f1bc88f 100644
--- a/fs/xfs/xfs_sysfs.c
+++ b/fs/xfs/xfs_sysfs.c
@@ -63,19 +63,6 @@ static const struct sysfs_ops xfs_sysfs_ops = {
.store = xfs_sysfs_object_store,
};
-/*
- * xfs_mount kobject. The mp kobject also serves as the per-mount parent object
- * that is identified by the fsname under sysfs.
- */
-
-static inline struct xfs_mount *
-to_mp(struct kobject *kobject)
-{
- struct xfs_kobj *kobj = to_kobj(kobject);
-
- return container_of(kobj, struct xfs_mount, m_kobj);
-}
-
static struct attribute *xfs_mp_attrs[] = {
NULL,
};
--
2.6.2
On Tue, Sep 24, 2019 at 05:53:50PM +0900, Austin Kim wrote:
> to_mp() was first introduced with the following commit:
> 'commit 801cc4e17a34c ("xfs: debug mode forced buffered write failure")'
>
> But the user of to_mp() was removed by below commit:
> 'commit f8c47250ba46e ("xfs: convert drop_writes to use the errortag
> mechanism")'
>
> So kernel build with clang throws below warning message:
>
> fs/xfs/xfs_sysfs.c:72:1: warning: unused function 'to_mp' [-Wunused-function]
> to_mp(struct kobject *kobject)
>
> Hence to_mp() might be removed safely to get rid of warning message.
>
> Signed-off-by: Austin Kim <[email protected]>
> ---
Reviewed-by: Brian Foster <[email protected]>
> fs/xfs/xfs_sysfs.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c
> index ddd0bf7..f1bc88f 100644
> --- a/fs/xfs/xfs_sysfs.c
> +++ b/fs/xfs/xfs_sysfs.c
> @@ -63,19 +63,6 @@ static const struct sysfs_ops xfs_sysfs_ops = {
> .store = xfs_sysfs_object_store,
> };
>
> -/*
> - * xfs_mount kobject. The mp kobject also serves as the per-mount parent object
> - * that is identified by the fsname under sysfs.
> - */
> -
> -static inline struct xfs_mount *
> -to_mp(struct kobject *kobject)
> -{
> - struct xfs_kobj *kobj = to_kobj(kobject);
> -
> - return container_of(kobj, struct xfs_mount, m_kobj);
> -}
> -
> static struct attribute *xfs_mp_attrs[] = {
> NULL,
> };
> --
> 2.6.2
>