2019-09-26 22:59:23

by Denis Efremov (Oracle)

Subject: [PATCH] ath9k_hw: fix uninitialized variable data

Currently, data variable in ar9003_hw_thermo_cal_apply() could be
uninitialized if ar9300_otp_read_word() will fail to read the value.
Initialize data variable with 0 to prevent an undefined behavior. This
will be enough to handle error case when ar9300_otp_read_word() fails.

Fixes: 80fe43f2bbd5 ("ath9k_hw: Read and configure thermocal for AR9462")
Cc: Rajkumar Manoharan <[email protected]>
Cc: John W. Linville <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
Signed-off-by: Denis Efremov <[email protected]>
---
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
index 2b29bf4730f6..b4885a700296 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
@@ -4183,7 +4183,7 @@ static void ar9003_hw_thermometer_apply(struct ath_hw *ah)

static void ar9003_hw_thermo_cal_apply(struct ath_hw *ah)
{
- u32 data, ko, kg;
+ u32 data = 0, ko, kg;

if (!AR_SREV_9462_20_OR_LATER(ah))
return;
--
2.21.0

2019-10-01 11:19:48

by Kalle Valo

Subject: Re: [PATCH] ath9k_hw: fix uninitialized variable data

Denis Efremov <[email protected]> wrote:

> Currently, data variable in ar9003_hw_thermo_cal_apply() could be
> uninitialized if ar9300_otp_read_word() will fail to read the value.
> Initialize data variable with 0 to prevent an undefined behavior. This
> will be enough to handle error case when ar9300_otp_read_word() fails.
>
> Fixes: 80fe43f2bbd5 ("ath9k_hw: Read and configure thermocal for AR9462")
> Cc: Rajkumar Manoharan <[email protected]>
> Cc: John W. Linville <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> Signed-off-by: Denis Efremov <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

80e84f36412e ath9k_hw: fix uninitialized variable data

--
https://patchwork.kernel.org/patch/11163437/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches