2019-10-01 12:48:44

by Marek Szyprowski

Subject: [PATCH] PM / devfreq: exynos-ppmu: remove useless assignment

The error code is propagated to the caller, so there is no need to keep
it additionally in the unused variable.

Signed-off-by: Marek Szyprowski <[email protected]>
---
drivers/devfreq/event/exynos-ppmu.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index 87b42055e6bc..85c7a77bf3f0 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -673,7 +673,6 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
for (i = 0; i < info->num_events; i++) {
edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
if (IS_ERR(edev[i])) {
- ret = PTR_ERR(edev[i]);
dev_err(&pdev->dev,
"failed to add devfreq-event device\n");
return PTR_ERR(edev[i]);
--
2.17.1

2019-10-02 05:00:16

by Chanwoo Choi

Subject: Re: [PATCH] PM / devfreq: exynos-ppmu: remove useless assignment

Hi,

On 19. 10. 1. 오후 9:46, Marek Szyprowski wrote:
> The error code is propagated to the caller, so there is no need to keep
> it additionally in the unused variable.
>
> Signed-off-by: Marek Szyprowski <[email protected]>
> ---
> drivers/devfreq/event/exynos-ppmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 87b42055e6bc..85c7a77bf3f0 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -673,7 +673,6 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
> for (i = 0; i < info->num_events; i++) {
> edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
> if (IS_ERR(edev[i])) {
> - ret = PTR_ERR(edev[i]);
> dev_err(&pdev->dev,
> "failed to add devfreq-event device\n");
> return PTR_ERR(edev[i]);
>

Thanks.
Acked-by: Chanwoo Choi <[email protected]>

--
Best Regards,
Chanwoo Choi
Samsung Electronics