2019-10-10 08:35:37

by Fuqian Huang

Subject: [PATCH] xen/grant-table: remove unnecessary printing

xen_auto_xlat_grant_frames.vaddr is definitely NULL in this case.
So the address printing is unnecessary.

Signed-off-by: Fuqian Huang <[email protected]>
---
drivers/xen/grant-table.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 7ea6fb6a2e5d..49b381e104ef 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -1363,8 +1363,7 @@ static int gnttab_setup(void)
if (xen_feature(XENFEAT_auto_translated_physmap) && gnttab_shared.addr == NULL) {
gnttab_shared.addr = xen_auto_xlat_grant_frames.vaddr;
if (gnttab_shared.addr == NULL) {
- pr_warn("gnttab share frames (addr=0x%08lx) is not mapped!\n",
- (unsigned long)xen_auto_xlat_grant_frames.vaddr);
+ pr_warn("gnttab share frames is not mapped!\n");
return -ENOMEM;
}
}
--
2.11.0

2019-10-10 08:49:09

by Jürgen Groß

Subject: Re: [PATCH] xen/grant-table: remove unnecessary printing

On 10.10.19 10:32, Fuqian Huang wrote:
> xen_auto_xlat_grant_frames.vaddr is definitely NULL in this case.
> So the address printing is unnecessary.
>
> Signed-off-by: Fuqian Huang <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>


Juergen