Subject: [PATCH] x86_64: Sparse warnings fix.


Fixes the following sparse warnings:

arch/x86_64/kernel/mce_amd.c:321:29: warning: Using plain integer as NULL pointer
arch/x86_64/kernel/mce_amd.c:410:41: warning: Using plain integer as NULL pointer

Signed-off-by: Luiz Capitulino <[email protected]>

arch/x86_64/kernel/mce_amd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86_64/kernel/mce_amd.c b/arch/x86_64/kernel/mce_amd.c
index 1f76175..ed5bc57 100644
--- a/arch/x86_64/kernel/mce_amd.c
+++ b/arch/x86_64/kernel/mce_amd.c
@@ -318,7 +318,7 @@ static struct kobj_type threshold_ktype
static __cpuinit int threshold_create_bank(unsigned int cpu, int bank)
{
int err = 0;
- struct threshold_bank *b = 0;
+ struct threshold_bank *b = NULL;

#ifdef CONFIG_SMP
if (cpu_core_id[cpu] && shared_bank[bank]) { /* symlink */
@@ -407,7 +407,7 @@ static __cpuinit void threshold_remove_b
if (shared_bank[bank] && atomic_read(&b->kobj.kref.refcount) > 2) {
sprintf(name, "bank%i", bank);
sysfs_remove_link(&per_cpu(device_threshold, cpu).kobj, name);
- per_cpu(threshold_banks, cpu)[bank] = 0;
+ per_cpu(threshold_banks, cpu)[bank] = NULL;
} else {
kobject_unregister(&b->kobj);
kfree(per_cpu(threshold_banks, cpu)[bank]);


--
Luiz Fernando N. Capitulino


2006-01-06 22:33:49

by Andi Kleen

[permalink] [raw]
Subject: Re: [PATCH] x86_64: Sparse warnings fix.

On Friday 06 January 2006 15:07, Luiz Fernando Capitulino wrote:
>
> Fixes the following sparse warnings:
>
> arch/x86_64/kernel/mce_amd.c:321:29: warning: Using plain integer as NULL pointer
> arch/x86_64/kernel/mce_amd.c:410:41: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Luiz Capitulino <[email protected]>


Queued. Thanks.

-Andi