2006-01-07 14:49:46

by Russell King

Subject: 2.6-git: BITS_PER_LONG

Hi.

With the latest git, I'm seeing a number of:

include/asm-generic/atomic.h:20:5: warning: "BITS_PER_LONG" is not defined

What's intended here? Should asm-generic/atomic.h include asm/types.h?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core

2006-01-09 17:57:59

by Christoph Lameter

Subject: Re: 2.6-git: BITS_PER_LONG

On Sat, 7 Jan 2006, Russell King wrote:

> Hi.
>
> With the latest git, I'm seeing a number of:
>
> include/asm-generic/atomic.h:20:5: warning: "BITS_PER_LONG" is not defined
>
> What's intended here? Should asm-generic/atomic.h include asm/types.h?

asm/types.h should be included by asm/atomic.h. Which arch is this?

2006-01-09 18:32:13

by Russell King

Subject: Re: 2.6-git: BITS_PER_LONG

On Mon, Jan 09, 2006 at 09:57:29AM -0800, Christoph Lameter wrote:
> On Sat, 7 Jan 2006, Russell King wrote:
> > With the latest git, I'm seeing a number of:
> >
> > include/asm-generic/atomic.h:20:5: warning: "BITS_PER_LONG" is not defined
> >
> > What's intended here? Should asm-generic/atomic.h include asm/types.h?
>
> asm/types.h should be included by asm/atomic.h.

Disagree - nothing in asm/atomic.h needs asm/types.h. If
asm-generic/atomic.h has this requirement, it should be the one
including asm/types.h (or should it be linux/types.h ?)

> Which arch is this?

ARM.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core