2019-10-23 17:01:22

by Matti Vaittinen

Subject: [PATCH] gpio: bd70528: Add MODULE ALIAS to autoload module

The bd70528 GPIO driver is probed by MFD driver. Add MODULE_ALIAS
in order to allow udev to load the module when MFD sub-device cell
for GPIO is added.

Fixes: 18bc64b3aebfa ("gpio: Initial support for ROHM bd70528 GPIO block")
Signed-off-by: Matti Vaittinen <[email protected]>
---
I'm not really sure if this is a bug-fix or feature but I guess the
Fixes tag won't harm, right?

drivers/gpio/gpio-bd70528.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-bd70528.c b/drivers/gpio/gpio-bd70528.c
index fd85605d2dab..8123260a92a2 100644
--- a/drivers/gpio/gpio-bd70528.c
+++ b/drivers/gpio/gpio-bd70528.c
@@ -230,3 +230,4 @@ module_platform_driver(bd70528_gpio);
MODULE_AUTHOR("Matti Vaittinen <[email protected]>");
MODULE_DESCRIPTION("BD70528 voltage regulator driver");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:bd70528-gpio");
--
2.21.0


--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]

2019-10-24 01:15:50

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: bd70528: Add MODULE ALIAS to autoload module

śr., 23 paź 2019 o 14:22 Matti Vaittinen
<[email protected]> napisał(a):
>
> The bd70528 GPIO driver is probed by MFD driver. Add MODULE_ALIAS
> in order to allow udev to load the module when MFD sub-device cell
> for GPIO is added.
>
> Fixes: 18bc64b3aebfa ("gpio: Initial support for ROHM bd70528 GPIO block")
> Signed-off-by: Matti Vaittinen <[email protected]>
> ---
> I'm not really sure if this is a bug-fix or feature but I guess the
> Fixes tag won't harm, right?

It's definitely a feature, not a bug-fix. I applied it to for-next but
dropped the tag.

Bart

>
> drivers/gpio/gpio-bd70528.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-bd70528.c b/drivers/gpio/gpio-bd70528.c
> index fd85605d2dab..8123260a92a2 100644
> --- a/drivers/gpio/gpio-bd70528.c
> +++ b/drivers/gpio/gpio-bd70528.c
> @@ -230,3 +230,4 @@ module_platform_driver(bd70528_gpio);
> MODULE_AUTHOR("Matti Vaittinen <[email protected]>");
> MODULE_DESCRIPTION("BD70528 voltage regulator driver");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:bd70528-gpio");
> --
> 2.21.0
>
>
> --
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
>
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =]

2019-10-29 19:40:10

by Matti Vaittinen

Subject: Re: [PATCH] gpio: bd70528: Add MODULE ALIAS to autoload module

On Wed, 2019-10-23 at 16:49 +0200, Bartosz Golaszewski wrote:
> śr., 23 paź 2019 o 14:22 Matti Vaittinen
>
> > I'm not really sure if this is a bug-fix or feature but I guess the
> > Fixes tag won't harm, right?
>
> It's definitely a feature, not a bug-fix. I applied it to for-next
> but
> dropped the tag.

Thanks!

--Matti