2019-11-19 06:24:30

by Dan Carpenter

[permalink] [raw]
Subject: [PATCH] io-wq: remove extra space characters

These lines are indented an extra space character.

Signed-off-by: Dan Carpenter <[email protected]>
---
We often see this where the lines after a comment are indented one
space extra. I don't know if it's an editor thing maybe?

fs/io-wq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/io-wq.c b/fs/io-wq.c
index fcb6c74209da..6d8f5e6c8167 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -333,9 +333,9 @@ static void __io_worker_busy(struct io_wqe *wqe, struct io_worker *worker,
* If worker is moving from bound to unbound (or vice versa), then
* ensure we update the running accounting.
*/
- worker_bound = (worker->flags & IO_WORKER_F_BOUND) != 0;
- work_bound = (work->flags & IO_WQ_WORK_UNBOUND) == 0;
- if (worker_bound != work_bound) {
+ worker_bound = (worker->flags & IO_WORKER_F_BOUND) != 0;
+ work_bound = (work->flags & IO_WQ_WORK_UNBOUND) == 0;
+ if (worker_bound != work_bound) {
io_wqe_dec_running(wqe, worker);
if (work_bound) {
worker->flags |= IO_WORKER_F_BOUND;
--
2.11.0



2019-11-19 15:49:06

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] io-wq: remove extra space characters

On 11/18/19 11:22 PM, Dan Carpenter wrote:
> These lines are indented an extra space character.

Thanks, applied.

> We often see this where the lines after a comment are indented one
> space extra. I don't know if it's an editor thing maybe?

I think I can explain that. I recently decided to try and use the
vim auto-indent, to see if it'd make my life a little easier to
save on typing. Unfortunately it has a bug where it indents that
extra space following a comment form like:

/*
* bla bla
*/

which is exactly what happened here. As diff doesn't show that
as extra whitespace you can miss that it happened.

--
Jens Axboe