2019-11-19 15:07:25

by Xianting Tian

[permalink] [raw]
Subject: [PATCH] bfq: Replace kmalloc_node with kzalloc_node

Replace kmalloc_node with kzalloc_node

Signed-off-by: Xianting Tian <[email protected]>
---
block/bfq-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 86a607c..9a84d79 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -1385,7 +1385,7 @@ struct bfq_group *bfq_create_group_hierarchy(struct bfq_data *bfqd, int node)
struct bfq_group *bfqg;
int i;

- bfqg = kmalloc_node(sizeof(*bfqg), GFP_KERNEL | __GFP_ZERO, node);
+ bfqg = kzalloc_node(sizeof(*bfqg), GFP_KERNEL, node);
if (!bfqg)
return NULL;

--
1.8.3.1



2019-12-03 15:42:09

by Michal Koutný

[permalink] [raw]
Subject: Re: [PATCH] bfq: Replace kmalloc_node with kzalloc_node

Hi Xianting.

On Tue, Nov 19, 2019 at 10:02:26AM -0500, Xianting Tian <[email protected]> wrote:
> Replace kmalloc_node with kzalloc_node
IIUC, your patch makes no functional change and from the message it's
not clear what's the motivation. Could you please make the commit
message more descriptive so that it can be evaluated?

Michal


Attachments:
(No filename) (350.00 B)
signature.asc (849.00 B)
Digital signature
Download all attachments