2019-12-05 15:14:55

by Hyunki Koo

Subject: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER

From: Hyunki Koo <[email protected]>

Not all exynos device have IRQ_COMBINER.
Thus add the config for EXYNOS_IRQ_COMBINER.

Signed-off-by: Hyunki Koo <[email protected]>
---
drivers/irqchip/Kconfig | 7 +++++++
drivers/irqchip/Makefile | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index ba152954324b..1fff899a6421 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -393,6 +393,13 @@ config STM32_EXTI
select IRQ_DOMAIN
select GENERIC_IRQ_CHIP

+config EXYNOS_IRQ_COMBINER
+ bool "Samsung Exynos IRQ combiner support"
+ depends on ARCH_EXYNOS
+ help
+ Say yes here to add support for the IRQ combiner devices embedded
+ in Samsung Exynos chips.
+
config QCOM_IRQ_COMBINER
bool "QCOM IRQ combiner support"
depends on ARCH_QCOM && ACPI
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index e806dda690ea..60d7c7260fc3 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o
obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o
obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o
obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o
-obj-$(CONFIG_ARCH_EXYNOS) += exynos-combiner.o
+obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o
obj-$(CONFIG_FARADAY_FTINTC010) += irq-ftintc010.o
obj-$(CONFIG_ARCH_HIP04) += irq-hip04.o
obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o
--
2.17.1

2019-12-05 15:38:46

by Krzysztof Kozlowski

Subject: Re: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER

On Thu, 5 Dec 2019 at 16:16, Hyunki Koo <[email protected]> wrote:
>
> From: Hyunki Koo <[email protected]>
>
> Not all exynos device have IRQ_COMBINER.
> Thus add the config for EXYNOS_IRQ_COMBINER.
>
> Signed-off-by: Hyunki Koo <[email protected]>
> ---
> drivers/irqchip/Kconfig | 7 +++++++
> drivers/irqchip/Makefile | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)

I do not have a clue what you want to achieve here. Where is the driver?

Best regards,
Krzysztof

2019-12-05 15:46:40

by Hyunki Koo

Subject: Re: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER

there is no new driver

I just want remove direct dependency between ARCH_EXYNOS and
exynos-combiner.c

because all exynos device is not needed the exynos-combiner

only used in aarch32 devices.


On 19. 12. 6. 오전 12:37, Krzysztof Kozlowski wrote:
> On Thu, 5 Dec 2019 at 16:16, Hyunki Koo <[email protected]> wrote:
>> From: Hyunki Koo <[email protected]>
>>
>> Not all exynos device have IRQ_COMBINER.
>> Thus add the config for EXYNOS_IRQ_COMBINER.
>>
>> Signed-off-by: Hyunki Koo <[email protected]>
>> ---
>> drivers/irqchip/Kconfig | 7 +++++++
>> drivers/irqchip/Makefile | 2 +-
>> 2 files changed, 8 insertions(+), 1 deletion(-)
> I do not have a clue what you want to achieve here. Where is the driver?
>
> Best regards,
> Krzysztof

2019-12-05 16:04:05

by Marc Zyngier

Subject: Re: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER

On 2019-12-05 15:44, Hyunki Koo wrote:
> there is no new driver
>
> I just want remove direct dependency between ARCH_EXYNOS and
> exynos-combiner.c
>
> because all exynos device is not needed the exynos-combiner
>
> only used in aarch32 devices.

So breaking all existing configurations (that will rely on this
driver to be selected by ARCH_EXYNOS) is absolutely fine, as long
as your pet machine is not "polluted" by an unnecessary driver?

I'm sorry, but that's not acceptable.

M.
--
Jazz is not dead. It just smells funny...