2020-02-09 08:41:24

by Peng Fan

Subject: [PATCH] PM: replace S_IRUGO with octal numbers

From: Peng Fan <[email protected]>

Per commit f90774e1fd27 ("checkpatch: look for symbolic permissions
and suggest octal instead"), octal numbers is preferred, so replace
S_IRUGO with octal numbers.

Signed-off-by: Peng Fan <[email protected]>
---
drivers/base/power/domain.c | 2 +-
drivers/base/power/wakeup.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 959d6d5eb000..0a2d0360c014 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -3054,7 +3054,7 @@ static int __init genpd_debug_init(void)

genpd_debugfs_dir = debugfs_create_dir("pm_genpd", NULL);

- debugfs_create_file("pm_genpd_summary", S_IRUGO, genpd_debugfs_dir,
+ debugfs_create_file("pm_genpd_summary", 0444, genpd_debugfs_dir,
NULL, &summary_fops);

list_for_each_entry(genpd, &gpd_list, gpd_list_node) {
diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 27f3e60608e5..7970797ad8f6 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -1174,7 +1174,7 @@ static const struct file_operations wakeup_sources_stats_fops = {

static int __init wakeup_sources_debugfs_init(void)
{
- debugfs_create_file("wakeup_sources", S_IRUGO, NULL, NULL,
+ debugfs_create_file("wakeup_sources", 0444, NULL, NULL,
&wakeup_sources_stats_fops);
return 0;
}
--
2.16.4

2020-02-10 00:02:45

by Rafael J. Wysocki

Subject: Re: [PATCH] PM: replace S_IRUGO with octal numbers

On Sun, Feb 9, 2020 at 9:39 AM <[email protected]> wrote:
>
> From: Peng Fan <[email protected]>
>
> Per commit f90774e1fd27 ("checkpatch: look for symbolic permissions
> and suggest octal instead"),

This applies to new patches.

> octal numbers is preferred, so replace S_IRUGO with octal numbers.

Not really.

Thanks!