2020-02-21 07:13:16

by Jianxin Pan

Subject: [PATCH] dt-bindings: power: Fix dt_binding_check error

Missing ';' in the end of secure-monitor example node.

Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings")
Reported-by: Rob Herring<[email protected]>
Signed-off-by: Jianxin Pan <[email protected]>
---
Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
index af32209..bc4e037 100644
--- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
+++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
@@ -36,5 +36,5 @@ examples:
compatible = "amlogic,meson-a1-pwrc";
#power-domain-cells = <1>;
};
- }
+ };

--
2.7.4

2020-02-21 08:27:29

by Neil Armstrong

Subject: Re: [PATCH] dt-bindings: power: Fix dt_binding_check error

On 21/02/2020 08:12, Jianxin Pan wrote:
> Missing ';' in the end of secure-monitor example node.
>
> Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings")
> Reported-by: Rob Herring<[email protected]>
> Signed-off-by: Jianxin Pan <[email protected]>
> ---
> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> index af32209..bc4e037 100644
> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> @@ -36,5 +36,5 @@ examples:
> compatible = "amlogic,meson-a1-pwrc";
> #power-domain-cells = <1>;
> };
> - }
> + };
>
>

Reviewed-by: Neil Armstrong <[email protected]>

2020-02-26 17:27:37

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: power: Fix dt_binding_check error

On Fri, Feb 21, 2020 at 03:12:48PM +0800, Jianxin Pan wrote:
> Missing ';' in the end of secure-monitor example node.
>
> Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings")
> Reported-by: Rob Herring<[email protected]>

space ^

> Signed-off-by: Jianxin Pan <[email protected]>
> ---
> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This error isn't in my tree, so make sure it's applied where the
referenced commit is.

Acked-by: Rob Herring <[email protected]>

>
> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> index af32209..bc4e037 100644
> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> @@ -36,5 +36,5 @@ examples:
> compatible = "amlogic,meson-a1-pwrc";
> #power-domain-cells = <1>;
> };
> - }
> + };
>
> --
> 2.7.4
>

2020-02-28 02:20:44

by Jianxin Pan

Subject: Re: [PATCH] dt-bindings: power: Fix dt_binding_check error

Hi Rob,

Thanks for the ACK.
I have resent it to Kevin for linux-amlogic and Stephen for linux-next.

On 2020/2/27 1:27, Rob Herring wrote:
> On Fri, Feb 21, 2020 at 03:12:48PM +0800, Jianxin Pan wrote:
>> Missing ';' in the end of secure-monitor example node.
>>
>> Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings")
>> Reported-by: Rob Herring<[email protected]>
>
> space ^
I fixed it in the resend version.
>
>> Signed-off-by: Jianxin Pan <[email protected]>
>> ---
>> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This error isn't in my tree, so make sure it's applied where the
> referenced commit is.
>
> Acked-by: Rob Herring <[email protected]>
>
>>
>> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> index af32209..bc4e037 100644
>> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> @@ -36,5 +36,5 @@ examples:
>> compatible = "amlogic,meson-a1-pwrc";
>> #power-domain-cells = <1>;
>> };
>> - }
>> + };
>>
>> --
>> 2.7.4
>>
>
> .
>