2020-02-22 17:11:22

by Colin King

Subject: [PATCH][next] ice: remove redundant assignment to pointer vsi

From: Colin Ian King <[email protected]>

Pointer vsi is being re-assigned a value that is never read,
the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index 169b72a94b9d..2c8e334c47a0 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -2191,7 +2191,6 @@ static int ice_vc_ena_qs_msg(struct ice_vf *vf, u8 *msg)
set_bit(vf_q_id, vf->rxq_ena);
}

- vsi = pf->vsi[vf->lan_vsi_idx];
q_map = vqs->tx_queues;
for_each_set_bit(vf_q_id, &q_map, ICE_MAX_BASE_QS_PER_VF) {
if (!ice_vc_isvalid_q_id(vf, vqs->vsi_id, vf_q_id)) {
--
2.25.0

2020-02-25 19:35:19

by Allan, Bruce W

Subject: RE: [Intel-wired-lan] [PATCH][next] ice: remove redundant assignment to pointer vsi

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Colin King
> Sent: Saturday, February 22, 2020 9:11 AM
> To: Kirsher, Jeffrey T <[email protected]>; David S . Miller
> <[email protected]>; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH][next] ice: remove redundant assignment to
> pointer vsi
>
> From: Colin Ian King <[email protected]>
>
> Pointer vsi is being re-assigned a value that is never read,
> the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")

What version of coverity and what options were used?

> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> index 169b72a94b9d..2c8e334c47a0 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> @@ -2191,7 +2191,6 @@ static int ice_vc_ena_qs_msg(struct ice_vf *vf, u8
> *msg)
> set_bit(vf_q_id, vf->rxq_ena);
> }
>
> - vsi = pf->vsi[vf->lan_vsi_idx];
> q_map = vqs->tx_queues;
> for_each_set_bit(vf_q_id, &q_map, ICE_MAX_BASE_QS_PER_VF) {
> if (!ice_vc_isvalid_q_id(vf, vqs->vsi_id, vf_q_id)) {
> --
> 2.25.0
>
> _______________________________________________
> Intel-wired-lan mailing list
> [email protected]
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

2020-02-26 22:08:18

by Bowers, AndrewX

Subject: RE: [Intel-wired-lan] [PATCH][next] ice: remove redundant assignment to pointer vsi

> -----Original Message-----
> From: Intel-wired-lan [mailto:[email protected]] On
> Behalf Of Colin King
> Sent: Saturday, February 22, 2020 9:11 AM
> To: Kirsher, Jeffrey T <[email protected]>; David S . Miller
> <[email protected]>; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH][next] ice: remove redundant assignment
> to pointer vsi
>
> From: Colin Ian King <[email protected]>
>
> Pointer vsi is being re-assigned a value that is never read, the assignment is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 1 -
> 1 file changed, 1 deletion(-)

Tested-by: Andrew Bowers <[email protected]>