2020-02-26 05:30:20

by Anson Huang

Subject: [PATCH] nvmem: imx-ocotp: Drop unnecessary initializations

Drop unnecessary initialization of variable 'clk_rate' and 'timing'.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/nvmem/imx-ocotp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
index 4ba9cc8..5b6a0c9 100644
--- a/drivers/nvmem/imx-ocotp.c
+++ b/drivers/nvmem/imx-ocotp.c
@@ -193,9 +193,9 @@ static int imx_ocotp_read(void *context, unsigned int offset,

static void imx_ocotp_set_imx6_timing(struct ocotp_priv *priv)
{
- unsigned long clk_rate = 0;
+ unsigned long clk_rate;
unsigned long strobe_read, relax, strobe_prog;
- u32 timing = 0;
+ u32 timing;

/* 47.3.1.3.1
* Program HW_OCOTP_TIMING[STROBE_PROG] and HW_OCOTP_TIMING[RELAX]
@@ -245,9 +245,9 @@ static void imx_ocotp_set_imx6_timing(struct ocotp_priv *priv)

static void imx_ocotp_set_imx7_timing(struct ocotp_priv *priv)
{
- unsigned long clk_rate = 0;
+ unsigned long clk_rate;
u64 fsource, strobe_prog;
- u32 timing = 0;
+ u32 timing;

/* i.MX 7Solo Applications Processor Reference Manual, Rev. 0.1
* 6.4.3.3
--
2.7.4

2020-03-05 17:54:21

by Srinivas Kandagatla

Subject: Re: [PATCH] nvmem: imx-ocotp: Drop unnecessary initializations

On 26/02/2020 05:22, Anson Huang wrote:
> Drop unnecessary initialization of variable 'clk_rate' and 'timing'.
>
> Signed-off-by: Anson Huang <[email protected]>

Applied thanks,
--srini