2020-02-29 16:11:08

by SZ Lin

Subject: [PATCH] kbuild: Fix inconsistent comment

The commit 2042b5486bd3 ("kbuild: unset variables in top Makefile
instead of setting 0") renamed the variable from "config-targets"
to "config-build", the comment should be consistent accordingly.

Signed-off-by: Kaiden PK Yu (余泊鎧) <[email protected]>
Signed-off-by: SZ Lin (林上智) <[email protected]>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 90ee2a22e88b..01ac935f28bd 100644
--- a/Makefile
+++ b/Makefile
@@ -1805,7 +1805,7 @@ existing-targets := $(wildcard $(sort $(targets)))

-include $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).cmd)

-endif # config-targets
+endif # config-build
endif # mixed-build
endif # need-sub-make

--
2.25.1

2020-03-01 01:06:31

by Masahiro Yamada

Subject: Re: [PATCH] kbuild: Fix inconsistent comment

On Sun, Mar 1, 2020 at 1:10 AM SZ Lin (林上智) <[email protected]> wrote:
>
> The commit 2042b5486bd3 ("kbuild: unset variables in top Makefile
> instead of setting 0") renamed the variable from "config-targets"
> to "config-build", the comment should be consistent accordingly.
>
> Signed-off-by: Kaiden PK Yu (余泊鎧) <[email protected]>
> Signed-off-by: SZ Lin (林上智) <[email protected]>
> ---


Applied to linux-kbuild.
Thanks.



> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 90ee2a22e88b..01ac935f28bd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1805,7 +1805,7 @@ existing-targets := $(wildcard $(sort $(targets)))
>
> -include $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).cmd)
>
> -endif # config-targets
> +endif # config-build
> endif # mixed-build
> endif # need-sub-make
>
> --
> 2.25.1
>


--
Best Regards
Masahiro Yamada