2020-03-15 01:33:09

by Anson Huang

Subject: [PATCH] rtc: snvs: remove redundant error message

The RTC core already has error message for registration failure,
no need to have error message in the driver again.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/rtc/rtc-snvs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
index 319ed1d..36f4961 100644
--- a/drivers/rtc/rtc-snvs.c
+++ b/drivers/rtc/rtc-snvs.c
@@ -354,8 +354,6 @@ static int snvs_rtc_probe(struct platform_device *pdev)
data->rtc->ops = &snvs_rtc_ops;
data->rtc->range_max = U32_MAX;
ret = rtc_register_device(data->rtc);
- if (ret)
- dev_err(&pdev->dev, "failed to register rtc: %d\n", ret);

return ret;
}
--
2.7.4

2020-03-15 12:27:52

by Alexandre Belloni

Subject: Re: [PATCH] rtc: snvs: remove redundant error message

Hi,

On 15/03/2020 08:47:44+0800, Anson Huang wrote:
> The RTC core already has error message for registration failure,
> no need to have error message in the driver again.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> drivers/rtc/rtc-snvs.c | 2 --
> 1 file changed, 2 deletions(-)
>

I squashed that one in your previous patch.


--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com