2020-04-02 11:42:09

by Xu Wang

[permalink] [raw]
Subject: [PATCH] scsi: cxgb4i: Remove unneeded null check

In do_abort_rpl_rss, the null check of 'clk'
is unneeded to be done twice.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index bc1086ae6835..8ce8592f6a64 100644
--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -1127,10 +1127,9 @@ static void do_abort_rpl_rss(struct cxgbi_device *cdev, struct sk_buff *skb)
if (!csk)
goto rel_skb;

- if (csk)
- pr_info_ipaddr("csk 0x%p,%u,0x%lx,%u, status %u.\n",
- (&csk->saddr), (&csk->daddr), csk,
- csk->state, csk->flags, csk->tid, rpl->status);
+ pr_info_ipaddr("csk 0x%p,%u,0x%lx,%u, status %u.\n",
+ (&csk->saddr), (&csk->daddr), csk,
+ csk->state, csk->flags, csk->tid, rpl->status);

if (rpl->status == CPL_ERR_ABORT_FAILED)
goto rel_skb;
--
2.17.1