2020-04-09 07:53:38

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] soc: imx8: select SOC_BUS

Compile-testing the driver can result in a link failure
when CONFIG_SOC_BUS is disabled:

x86_64-linux-ld: drivers/soc/imx/soc-imx8m.o: in function `imx8_soc_init':
soc-imx8m.c:(.init.text+0x28d): undefined reference to `soc_device_register'

Select it from Kconfig, as we do from the other SoC drivers.

Fixes: fc40200ebf82 ("soc: imx: increase build coverage for imx8m soc driver")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/soc/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 67aa94b2481b..d515d2cc20ed 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -21,6 +21,7 @@ config SOC_IMX8M
bool "i.MX8M SoC family support"
depends on ARCH_MXC || COMPILE_TEST
default ARCH_MXC && ARM64
+ select SOC_BUS
help
If you say yes here you get support for the NXP i.MX8M family
support, it will provide the SoC info like SoC family,
--
2.26.0


2020-04-09 09:01:28

by Peng Fan

[permalink] [raw]
Subject: RE: [PATCH] soc: imx8: select SOC_BUS

> Subject: [PATCH] soc: imx8: select SOC_BUS
>
> Compile-testing the driver can result in a link failure when CONFIG_SOC_BUS
> is disabled:
>
> x86_64-linux-ld: drivers/soc/imx/soc-imx8m.o: in function `imx8_soc_init':
> soc-imx8m.c:(.init.text+0x28d): undefined reference to `soc_device_register'
>
> Select it from Kconfig, as we do from the other SoC drivers.
>
> Fixes: fc40200ebf82 ("soc: imx: increase build coverage for imx8m soc driver")
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Peng Fan <[email protected]>

Thanks,
Peng.