2020-04-10 19:37:12

by Matt Helsley

[permalink] [raw]
Subject: [RFC][PATCH 01/36] objtool: Exit successfully when requesting help

When the user requests help it's not an error so do not exit with
a non-zero exit code. This is not especially useful for a user but
any script that might wish to check that objtool --help is at least
available can't rely on the exit code to crudely check that, for
example building an objtool executable succeeds.

Signed-off-by: Matt Helsley <[email protected]>
---
tools/objtool/objtool.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c
index 0b3528f05053..593ec85915a9 100644
--- a/tools/objtool/objtool.c
+++ b/tools/objtool/objtool.c
@@ -58,7 +58,10 @@ static void cmd_usage(void)

printf("\n");

- exit(129);
+ if (!help)
+ exit(129);
+ else
+ exit(0);
}

static void handle_options(int *argc, const char ***argv)
--
2.20.1