2020-04-11 16:58:16

by Martin Blumenstingl

Subject: [PATCH v5] dt-bindings: gpu: mali-utgard: Add the #cooling-cells property

The GPU can be one of the big heat sources on a SoC. Allow the
"#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
overheating.

Reviewed-by: Qiang Yu <[email protected]>
Signed-off-by: Martin Blumenstingl <[email protected]>
---
Changes since v4 at [0]:
- Added Qiang's Reviewed-by (many thanks)
- re-send because I missed the devicetree mailing list in v4


[0] https://patchwork.kernel.org/patch/11448013/


Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
index f5401cc8de4a..4869258daadb 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
@@ -107,6 +107,9 @@ properties:

operating-points-v2: true

+ "#cooling-cells":
+ const: 2
+
required:
- compatible
- reg
@@ -164,6 +167,7 @@ examples:
clocks = <&ccu 1>, <&ccu 2>;
clock-names = "bus", "core";
resets = <&ccu 1>;
+ #cooling-cells = <2>;
};

...
--
2.26.0

2020-04-15 23:43:00

by Neil Armstrong

Subject: Re: [PATCH v5] dt-bindings: gpu: mali-utgard: Add the #cooling-cells property

On 11/04/2020 18:57, Martin Blumenstingl wrote:
> The GPU can be one of the big heat sources on a SoC. Allow the
> "#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
> the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
> overheating.
>
> Reviewed-by: Qiang Yu <[email protected]>
> Signed-off-by: Martin Blumenstingl <[email protected]>
> ---
> Changes since v4 at [0]:
> - Added Qiang's Reviewed-by (many thanks)
> - re-send because I missed the devicetree mailing list in v4
>
>
> [0] https://patchwork.kernel.org/patch/11448013/
>
>
> Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
> index f5401cc8de4a..4869258daadb 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
> @@ -107,6 +107,9 @@ properties:
>
> operating-points-v2: true
>
> + "#cooling-cells":
> + const: 2
> +
> required:
> - compatible
> - reg
> @@ -164,6 +167,7 @@ examples:
> clocks = <&ccu 1>, <&ccu 2>;
> clock-names = "bus", "core";
> resets = <&ccu 1>;
> + #cooling-cells = <2>;
> };
>
> ...
>

Reviewed-by: Neil Armstrong <[email protected]>

2020-04-20 19:17:01

by Rob Herring (Arm)

Subject: Re: [PATCH v5] dt-bindings: gpu: mali-utgard: Add the #cooling-cells property

On Sat, 11 Apr 2020 18:57:00 +0200, Martin Blumenstingl wrote:
> The GPU can be one of the big heat sources on a SoC. Allow the
> "#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
> the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
> overheating.
>
> Reviewed-by: Qiang Yu <[email protected]>
> Signed-off-by: Martin Blumenstingl <[email protected]>
> ---
> Changes since v4 at [0]:
> - Added Qiang's Reviewed-by (many thanks)
> - re-send because I missed the devicetree mailing list in v4
>
>
> [0] https://patchwork.kernel.org/patch/11448013/
>
>
> Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>

Applied, thanks.

Rob