2020-04-18 06:44:37

by Jason Yan

Subject: [PATCH] gcc-plugins: structleak: remove unneeded variable 'ret'

Fix the following coccicheck warning:

scripts/gcc-plugins/structleak_plugin.c:177:14-17: Unneeded variable:
"ret". Return "0" on line 207

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
scripts/gcc-plugins/structleak_plugin.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/gcc-plugins/structleak_plugin.c b/scripts/gcc-plugins/structleak_plugin.c
index e89be8f5c859..fdff6278eda0 100644
--- a/scripts/gcc-plugins/structleak_plugin.c
+++ b/scripts/gcc-plugins/structleak_plugin.c
@@ -174,7 +174,6 @@ static void initialize(tree var)
static unsigned int structleak_execute(void)
{
basic_block bb;
- unsigned int ret = 0;
tree var;
unsigned int i;

@@ -204,7 +203,7 @@ static unsigned int structleak_execute(void)
initialize(var);
}

- return ret;
+ return 0;
}

#define PASS_NAME structleak
--
2.21.1

2021-03-04 07:39:07

by Kees Cook

Subject: Re: [PATCH] gcc-plugins: structleak: remove unneeded variable 'ret'

On Sat, 18 Apr 2020 15:05:05 +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> scripts/gcc-plugins/structleak_plugin.c:177:14-17: Unneeded variable:
> "ret". Return "0" on line 207

Applied to for-next/gcc-plugins, thanks!

[1/1] gcc-plugins: structleak: remove unneeded variable 'ret'
https://git.kernel.org/kees/c/b924a8197ac7

--
Kees Cook