2020-04-21 03:42:40

by Jason Yan

Subject: [PATCH] scsi: bnx2fc: remove unneeded semicolon in bnx2fc_fcoe.c

Fix the following coccicheck warning:

drivers/scsi/bnx2fc/bnx2fc_fcoe.c:948:4-5: Unneeded semicolon
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:968:4-5: Unneeded semicolon

Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 1cbb431fa682..0e33324e16f5 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -945,7 +945,7 @@ static void bnx2fc_indicate_netevent(void *context, unsigned long event,
*/
if (interface->enabled)
fcoe_ctlr_link_up(ctlr);
- };
+ }
} else if (fcoe_ctlr_link_down(ctlr)) {
switch (cdev->enabled) {
case FCOE_CTLR_DISABLED:
@@ -965,7 +965,7 @@ static void bnx2fc_indicate_netevent(void *context, unsigned long event,
put_cpu();
fcoe_clean_pending_queue(lport);
wait_for_upload = 1;
- };
+ }
}
}
mutex_unlock(&bnx2fc_dev_lock);
--
2.21.1

2020-04-27 20:25:45

by Martin K. Petersen

Subject: Re: [PATCH] scsi: bnx2fc: remove unneeded semicolon in bnx2fc_fcoe.c

On Tue, 21 Apr 2020 11:40:19 +0800, Jason Yan wrote:

> Fix the following coccicheck warning:
>
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c:948:4-5: Unneeded semicolon
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c:968:4-5: Unneeded semicolon

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: bnx2fc: Remove unneeded semicolon in bnx2fc_fcoe.c
https://git.kernel.org/mkp/scsi/c/acfcb728bd57

--
Martin K. Petersen Oracle Linux Engineering