2020-04-25 15:42:56

by Johan Jonker

[permalink] [raw]
Subject: [PATCH] dt-bindings: gpu: add power-domains #cooling-cells to arm,mali-bifrost.yaml

A test with the command below gives this error:

arch/arm64/boot/dts/rockchip/px30-evb.dt.yaml: gpu@ff400000:
'#cooling-cells', 'power-domains'
do not match any of the regexes: 'pinctrl-[0-9]+'

With the conversion to yaml it also filters things
in a node that are used by other drivers like
'#cooling-cells' and 'power-domains'
for Rockchip px30 gpu nodes,
so add them to 'arm,mali-bifrost.yaml'.

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpu/
arm,mali-bifrost.yaml

Signed-off-by: Johan Jonker <[email protected]>
---
Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
index 0b229a7d4..b1844b9c2 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
@@ -43,9 +43,15 @@ properties:

operating-points-v2: true

+ power-domains:
+ maxItems: 1
+
resets:
maxItems: 2

+ "#cooling-cells":
+ const: 2
+
required:
- compatible
- reg
--
2.11.0


2020-05-11 22:27:34

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: gpu: add power-domains #cooling-cells to arm, mali-bifrost.yaml

On Sat, 25 Apr 2020 17:40:37 +0200, Johan Jonker wrote:
> A test with the command below gives this error:
>
> arch/arm64/boot/dts/rockchip/px30-evb.dt.yaml: gpu@ff400000:
> '#cooling-cells', 'power-domains'
> do not match any of the regexes: 'pinctrl-[0-9]+'
>
> With the conversion to yaml it also filters things
> in a node that are used by other drivers like
> '#cooling-cells' and 'power-domains'
> for Rockchip px30 gpu nodes,
> so add them to 'arm,mali-bifrost.yaml'.
>
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpu/
> arm,mali-bifrost.yaml
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>

Applied, thanks!