Hello,
I had to add a new entry to the hdaps_whitelist table in hdaps.c to get
my Thinkpad R52 recognized. Patch is attached
Frank
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
On Tue, Mar 14, 2006 at 09:57:58PM +0100, Frank Gevaerts wrote:
> Hello,
Hi Frank,
> I had to add a new entry to the hdaps_whitelist table in hdaps.c to get
> my Thinkpad R52 recognized. Patch is attached
please resend your patch:
- inline in the email (not an attachment) and
- with a Signed-off-by: line
> Frank
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Saturday 25 March 2006 22:09, you wrote:
> On Tue, Mar 14, 2006 at 09:57:58PM +0100, Frank Gevaerts wrote:
> > Hello,
>
> Hi Frank,
>
> > I had to add a new entry to the hdaps_whitelist table in hdaps.c to get
> > my Thinkpad R52 recognized. Patch is attached
>
> please resend your patch:
> - inline in the email (not an attachment) and
> - with a Signed-off-by: line
Here is a patch for Z60m. hdaps seems working fine - pivot utility reports values
that match description by R. Love sent to this ml few months ago.
Signed-off-by: Arkadiusz Miskiewicz <[email protected]>
--- linux-2.6.16/drivers/hwmon/hdaps.c.org 2006-03-26 00:30:53.000000000 +0100
+++ linux-2.6.16/drivers/hwmon/hdaps.c 2006-03-26 00:31:30.000000000 +0100
@@ -528,6 +528,7 @@
HDAPS_DMI_MATCH_NORMAL("ThinkPad X40"),
HDAPS_DMI_MATCH_NORMAL("ThinkPad X41 Tablet"),
HDAPS_DMI_MATCH_NORMAL("ThinkPad X41"),
+ HDAPS_DMI_MATCH_NORMAL("ThinkPad Z60m"),
{ .ident = NULL }
};
>
> > Frank
>
> TIA
> Adrian
--
Arkadiusz Mi?kiewicz PLD/Linux Team
http://www.t17.ds.pwr.wroc.pl/~misiek/ http://ftp.pld-linux.org/
Hi Frank,
> I had to add a new entry to the hdaps_whitelist table in hdaps.c to get
> my Thinkpad R52 recognized. Patch is attached
> (...)
> /* Note that DMI_MATCH(...,"ThinkPad T42") will match "ThinkPad T42p" */
> struct dmi_system_id hdaps_whitelist[] = {
> + HDAPS_DMI_MATCH_NORMAL("ThinkPad H"),
> HDAPS_DMI_MATCH_INVERT("ThinkPad R50p"),
> HDAPS_DMI_MATCH_NORMAL("ThinkPad R50"),
> HDAPS_DMI_MATCH_NORMAL("ThinkPad R51"),
I have some doubt about this. The Thinkpad R52 is already supported
(with identifier string "ThinkPad R52", unsuprisingly) and "ThinkPad H"
doesn't exactly sound sane. Looks like your DMI data is corrupted or
something. Could you please provide the output of dmidecode and
vpddecode on your laptop?
Anyone else with a Thinkpad R52 can provide the same information for
comparison?
Feel free to send the outputs to me privately if you don't want to make
them public.
Thanks,
--
Jean Delvare
Hi Arkadiusz,
> Here is a patch for Z60m. hdaps seems working fine - pivot utility reports values
> that match description by R. Love sent to this ml few months ago.
>
> Signed-off-by: Arkadiusz Miskiewicz <[email protected]>
>
> --- linux-2.6.16/drivers/hwmon/hdaps.c.org 2006-03-26 00:30:53.000000000 +0100
> +++ linux-2.6.16/drivers/hwmon/hdaps.c 2006-03-26 00:31:30.000000000 +0100
> @@ -528,6 +528,7 @@
> HDAPS_DMI_MATCH_NORMAL("ThinkPad X40"),
> HDAPS_DMI_MATCH_NORMAL("ThinkPad X41 Tablet"),
> HDAPS_DMI_MATCH_NORMAL("ThinkPad X41"),
> + HDAPS_DMI_MATCH_NORMAL("ThinkPad Z60m"),
> { .ident = NULL }
> };
OK, I grabbed this, and will merge it into another patch altering the
same device list.
Thanks,
--
Jean Delvare
On Tue, Mar 28, 2006 at 06:29:33PM +0200, Jean Delvare wrote:
> Hi Frank,
>
> > I had to add a new entry to the hdaps_whitelist table in hdaps.c to get
> > my Thinkpad R52 recognized. Patch is attached
> > (...)
> > /* Note that DMI_MATCH(...,"ThinkPad T42") will match "ThinkPad T42p" */
> > struct dmi_system_id hdaps_whitelist[] = {
> > + HDAPS_DMI_MATCH_NORMAL("ThinkPad H"),
> > HDAPS_DMI_MATCH_INVERT("ThinkPad R50p"),
> > HDAPS_DMI_MATCH_NORMAL("ThinkPad R50"),
> > HDAPS_DMI_MATCH_NORMAL("ThinkPad R51"),
>
> I have some doubt about this. The Thinkpad R52 is already supported
> (with identifier string "ThinkPad R52", unsuprisingly) and "ThinkPad H"
> doesn't exactly sound sane. Looks like your DMI data is corrupted or
> something. Could you please provide the output of dmidecode and
> vpddecode on your laptop?
They are attached.
Frank
> Anyone else with a Thinkpad R52 can provide the same information for
> comparison?
>
> Feel free to send the outputs to me privately if you don't want to make
> them public.
>
> Thanks,
> --
> Jean Delvare
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
This adds support for my Thinkpad R52, which for some reason is not
matched by the "ThinkPad R52" line.
Signed-off-by: Frank Gevaerts <[email protected]>
diff -ur linux-2.6.16-rc4/drivers/hwmon/hdaps.c linux-2.6.16-rc4-fg/drivers/hwmon/hdaps.c
--- linux-2.6.16-rc4/drivers/hwmon/hdaps.c 2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.16-rc4-fg/drivers/hwmon/hdaps.c 2006-02-24 13:25:53.000000000 +0100
@@ -515,6 +515,7 @@
/* Note that DMI_MATCH(...,"ThinkPad T42") will match "ThinkPad T42p" */
struct dmi_system_id hdaps_whitelist[] = {
+ HDAPS_DMI_MATCH_NORMAL("ThinkPad H"),
HDAPS_DMI_MATCH_INVERT("ThinkPad R50p"),
HDAPS_DMI_MATCH_NORMAL("ThinkPad R50"),
HDAPS_DMI_MATCH_NORMAL("ThinkPad R51"),
Hi Franck,
Quoting myself back in April:
> > I just had a mail from another R52 user, reporting that his system
> > (also 1846AQG) also reports ThinkPad H.
>
> I gathered data on my side too, the three R52 I had reports for used
> "ThinkPad R52" but these had different machine type/model. I guess that
> the 1846AQG is somehow different, but probably you don't know why?
>
> So I suppose we could add that "ThinkPad H" identifier string to the
> hdaps driver after all, as you proposed in the first place. I'm only
> worried that the "H" suffix is really short, and I hope that no other
> model not supported by the driver (or needing the invert option) will
> ever have the same identifier. Time will tell.
I am told that a newer BIOS of the Thinkpad R52 fixes the machine name
in the DMI table.
http://www.thinkwiki.org/wiki/List_of_DMI_IDs#R_series
Can you please confirm this by upgrading the BIOS of your machine and
removing the "ThinkPad H" entry from the hdaps driver?
Thanks,
--
Jean Delvare
On Wed, Oct 11, 2006 at 04:07:45PM +0200, Jean Delvare wrote:
> Hi Franck,
>
> Quoting myself back in April:
> > > I just had a mail from another R52 user, reporting that his system
> > > (also 1846AQG) also reports ThinkPad H.
> >
> > I gathered data on my side too, the three R52 I had reports for used
> > "ThinkPad R52" but these had different machine type/model. I guess that
> > the 1846AQG is somehow different, but probably you don't know why?
> >
> > So I suppose we could add that "ThinkPad H" identifier string to the
> > hdaps driver after all, as you proposed in the first place. I'm only
> > worried that the "H" suffix is really short, and I hope that no other
> > model not supported by the driver (or needing the invert option) will
> > ever have the same identifier. Time will tell.
>
> I am told that a newer BIOS of the Thinkpad R52 fixes the machine name
> in the DMI table.
> http://www.thinkwiki.org/wiki/List_of_DMI_IDs#R_series
> Can you please confirm this by upgrading the BIOS of your machine and
> removing the "ThinkPad H" entry from the hdaps driver?
BIOS 1.25 does indeed report "ThinkPad R52" instead of "ThinkPad H", and
hdaps without "ThinkPad H" works as expected.
Frank
>
> Thanks,
> --
> Jean Delvare
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan