2006-03-16 03:54:35

by Shaohua Li

Subject: [PATCH]swsusp: drain high mem pages

Highmem could be in pcp list as well.

Signed-off-by: Shaohua Li<[email protected]>
---

linux-2.6.15-root/kernel/power/snapshot.c | 1 +
1 files changed, 1 insertion(+)

diff -puN kernel/power/snapshot.c~drain_highmem kernel/power/snapshot.c
--- linux-2.6.15/kernel/power/snapshot.c~drain_highmem 2006-03-14 13:38:16.000000000 +0800
+++ linux-2.6.15-root/kernel/power/snapshot.c 2006-03-14 14:13:30.000000000 +0800
@@ -120,6 +120,7 @@ int save_highmem(void)
int res = 0;

pr_debug("swsusp: Saving Highmem\n");
+ drain_local_pages();
for_each_zone (zone) {
if (is_highmem(zone))
res = save_highmem_zone(zone);
_

2006-03-16 09:12:04

by Pavel Machek

Subject: Re: [PATCH]swsusp: drain high mem pages

On Čt 16-03-06 11:53:22, Shaohua Li wrote:
> Highmem could be in pcp list as well.

This explains some strangeness I was seeing before.

OTOH it is nothing but ugly these days, so this is not urgent for 2.6.16.

ACK.
Pavel

> Signed-off-by: Shaohua Li<[email protected]>
> ---
>
> linux-2.6.15-root/kernel/power/snapshot.c | 1 +
> 1 files changed, 1 insertion(+)
>
> diff -puN kernel/power/snapshot.c~drain_highmem kernel/power/snapshot.c
> --- linux-2.6.15/kernel/power/snapshot.c~drain_highmem 2006-03-14 13:38:16.000000000 +0800
> +++ linux-2.6.15-root/kernel/power/snapshot.c 2006-03-14 14:13:30.000000000 +0800
> @@ -120,6 +120,7 @@ int save_highmem(void)
> int res = 0;
>
> pr_debug("swsusp: Saving Highmem\n");
> + drain_local_pages();
> for_each_zone (zone) {
> if (is_highmem(zone))
> res = save_highmem_zone(zone);
> _
>

--
220: * This program is distributed in the hope that it will be useful,