2020-06-04 22:47:54

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the sound-current tree

Hi all,

After merging the sound-current tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

/home/sfr/next/next/sound/usb/card.c: In function 'snd_usb_autoresume':
/home/sfr/next/next/sound/usb/card.c:841:29: error: expected ';' before ')' token
841 | atomic_dec(&chip->active))
| ^
| ;

Caused by commit

3398e5c7b038 ("ALSA: usb-audio: Manage auto-pm of all bundled interfaces")

I have reverted that commit for today.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-06-05 02:20:44

by Macpaul Lin

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the sound-current tree

On Fri, 2020-06-05 at 08:43 +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-current tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> /home/sfr/next/next/sound/usb/card.c: In function 'snd_usb_autoresume':
> /home/sfr/next/next/sound/usb/card.c:841:29: error: expected ';' before ')' token
> 841 | atomic_dec(&chip->active))
> | ^
> | ;
>
> Caused by commit
>
> 3398e5c7b038 ("ALSA: usb-audio: Manage auto-pm of all bundled interfaces")
>
> I have reverted that commit for today.
>

Sorry I've tested its function by "patch back" to older kernel version
4.14.
After checking the latest patch again, there is indeed a typo here.

Thanks
Macpaul Lin

2020-06-05 06:42:18

by Takashi Iwai

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the sound-current tree

On Fri, 05 Jun 2020 04:18:29 +0200,
Macpaul Lin wrote:
>
> On Fri, 2020-06-05 at 08:43 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the sound-current tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > /home/sfr/next/next/sound/usb/card.c: In function 'snd_usb_autoresume':
> > /home/sfr/next/next/sound/usb/card.c:841:29: error: expected ';' before ')' token
> > 841 | atomic_dec(&chip->active))
> > | ^
> > | ;
> >
> > Caused by commit
> >
> > 3398e5c7b038 ("ALSA: usb-audio: Manage auto-pm of all bundled interfaces")
> >
> > I have reverted that commit for today.
> >
>
> Sorry I've tested its function by "patch back" to older kernel version
> 4.14.
> After checking the latest patch again, there is indeed a typo here.

Sorry for the mess, somehow a wrong version was pushed and merged.
I also tested but overlooked it...

Will scratch and resubmit the corrected one.


Takashi