2000-11-12 20:16:26

by David Brownell

[permalink] [raw]
Subject: Fw: [linux-usb-devel] 2.4.0-test11-pre3: Compile error in drivers/usb/usb.c

See the attached patch.

Also, for LKML readers, you may be interested in the attached
/sbin/hotplug script; it's pretty current, even if it may not
be the latest from CVS (at http://linux-usb.sourceforge.net/).

- Dave

----- Original Message -----
From: "David Brownell" <[email protected]>
To: <[email protected]>
Cc: "Dunlap, Randy" <[email protected]>
Sent: Sunday, 12 November, 2000 11:57 AM
Subject: Re: [linux-usb-devel] 2.4.0-tst11-pre3 fails compiling "usb.c":723: `hotplug_path'

> OK, try this patch (AFAICT suitable for pre3++), which does
> the following:
> - You can compile USB without CONFIG_HOTPLUG again.
> (I don't know who broke that; likely it came with
> the kernel/kmod.c cleanup.)
> - Restores interface altsetting if no kernel driver
> claims the device ... fixes a problem I noticed
> when hotplugging a printer cable (likely the same
> problem Stephen Gowdy has reported).
> - Restores accidentally-deleted code to pass INTERFACE,
> also needed to hotplug that printer cable.
> - Deletes the fixed point BCD formatting for product
> version code -- messy, and not needed. (This should
> at most affect /etc/usb/drivers/usb-storage, but
> that'll go away anyway with a MODULE_DEVICE_TABLE.)
> - Adds Documentation/usb/hotplug.txt ... half relates
> to generic hotplug stuff, the rest is USB-specific;
> just gives an overview to tie things together.
> FWIW I've tried most of the USB devices I have handy, and
> they all hotplugged OK using just "modules.usbmap" contents
> except that "keybdev" didn't load for a keyboard. (That's
> after those two interface related fixes.)
> - Dave

pre3-usb-hotplug.patch (9.24 kB)
hotplug (10.82 kB)
Download all attachments