2020-06-18 00:12:00

by Antonio Borneo

Subject: [PATCH] usbip: tools: fix module name in man page

Commit 64e62426f40d ("staging: usbip: edit Kconfig and rename
CONFIG options") renamed the module usbip as usbip-host, but the
example in the man page still reports the old module name.

Fix the module name in usbipd.8

Signed-off-by: Antonio Borneo <[email protected]>
Fixes: 64e62426f40d ("staging: usbip: edit Kconfig and rename CONFIG options")
---
tools/usb/usbip/doc/usbipd.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/usb/usbip/doc/usbipd.8 b/tools/usb/usbip/doc/usbipd.8
index ac4635db3f03..fb62a756893b 100644
--- a/tools/usb/usbip/doc/usbipd.8
+++ b/tools/usb/usbip/doc/usbipd.8
@@ -73,7 +73,7 @@ USB/IP client can connect and use exported devices.

.SH EXAMPLES

- server:# modprobe usbip
+ server:# modprobe usbip-host

server:# usbipd -D
- Start usbip daemon.

base-commit: b3a9e3b9622ae10064826dccb4f7a52bd88c7407
--
2.27.0

2020-06-18 18:43:18

by Shuah Khan

Subject: Re: [PATCH] usbip: tools: fix module name in man page

On 6/17/20 6:08 PM, Antonio Borneo wrote:
> Commit 64e62426f40d ("staging: usbip: edit Kconfig and rename
> CONFIG options") renamed the module usbip as usbip-host, but the
> example in the man page still reports the old module name.
>
> Fix the module name in usbipd.8
>
> Signed-off-by: Antonio Borneo <[email protected]>
> Fixes: 64e62426f40d ("staging: usbip: edit Kconfig and rename CONFIG options")
> ---
> tools/usb/usbip/doc/usbipd.8 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/usb/usbip/doc/usbipd.8 b/tools/usb/usbip/doc/usbipd.8
> index ac4635db3f03..fb62a756893b 100644
> --- a/tools/usb/usbip/doc/usbipd.8
> +++ b/tools/usb/usbip/doc/usbipd.8
> @@ -73,7 +73,7 @@ USB/IP client can connect and use exported devices.
>
> .SH EXAMPLES
>
> - server:# modprobe usbip
> + server:# modprobe usbip-host
>
> server:# usbipd -D
> - Start usbip daemon.
>
> base-commit: b3a9e3b9622ae10064826dccb4f7a52bd88c7407
>

Looks good. Thanks for fixing this.

Acked-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2020-06-18 18:49:02

by Shuah Khan

Subject: Re: [PATCH] usbip: tools: fix module name in man page

On 6/18/20 10:56 AM, Shuah Khan wrote:
> On 6/17/20 6:08 PM, Antonio Borneo wrote:
>> Commit 64e62426f40d ("staging: usbip: edit Kconfig and rename
>> CONFIG options") renamed the module usbip as usbip-host, but the
>> example in the man page still reports the old module name.
>>
>> Fix the module name in usbipd.8
>>
>> Signed-off-by: Antonio Borneo <[email protected]>
>> Fixes: 64e62426f40d ("staging: usbip: edit Kconfig and rename CONFIG
>> options")
>> ---
>>   tools/usb/usbip/doc/usbipd.8 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/usb/usbip/doc/usbipd.8 b/tools/usb/usbip/doc/usbipd.8
>> index ac4635db3f03..fb62a756893b 100644
>> --- a/tools/usb/usbip/doc/usbipd.8
>> +++ b/tools/usb/usbip/doc/usbipd.8
>> @@ -73,7 +73,7 @@ USB/IP client can connect and use exported devices.
>>   .SH EXAMPLES
>> -    server:# modprobe usbip
>> +    server:# modprobe usbip-host
>>       server:# usbipd -D
>>           - Start usbip daemon.
>>
>> base-commit: b3a9e3b9622ae10064826dccb4f7a52bd88c7407
>>
>
> Looks good. Thanks for fixing this.
>
> Acked-by: Shuah Khan <[email protected]>
>

+ Adding Greg

Odd. Looks like get_maintainers gave a very old address
for Greg Kroah-Hartman <[email protected]>.


thanks,
-- Shuah