2020-07-04 07:27:50

by Baolin Wang

Subject: [PATCH] blk-mq: Remove unnecessary local variable

Remove unnecessary local variable 'ret' in blk_mq_dispatch_hctx_list().

Signed-off-by: Baolin Wang <[email protected]>
---
block/blk-mq-sched.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
index 1c52e56a19b1..b8db72cf1043 100644
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -96,7 +96,6 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list)
struct request *rq;
LIST_HEAD(hctx_list);
unsigned int count = 0;
- bool ret;

list_for_each_entry(rq, rq_list, queuelist) {
if (rq->mq_hctx != hctx) {
@@ -108,8 +107,7 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list)
list_splice_tail_init(rq_list, &hctx_list);

dispatch:
- ret = blk_mq_dispatch_rq_list(hctx, &hctx_list, count);
- return ret;
+ return blk_mq_dispatch_rq_list(hctx, &hctx_list, count);
}

#define BLK_MQ_BUDGET_DELAY 3 /* ms units */
--
2.17.1

2020-07-10 08:23:34

by Baolin Wang

Subject: Re: [PATCH] blk-mq: Remove unnecessary local variable

Hi,

On Sat, Jul 04, 2020 at 03:26:14PM +0800, Baolin Wang wrote:
> Remove unnecessary local variable 'ret' in blk_mq_dispatch_hctx_list().
>

A gentle ping?

> Signed-off-by: Baolin Wang <[email protected]>
> ---
> block/blk-mq-sched.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
> index 1c52e56a19b1..b8db72cf1043 100644
> --- a/block/blk-mq-sched.c
> +++ b/block/blk-mq-sched.c
> @@ -96,7 +96,6 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list)
> struct request *rq;
> LIST_HEAD(hctx_list);
> unsigned int count = 0;
> - bool ret;
>
> list_for_each_entry(rq, rq_list, queuelist) {
> if (rq->mq_hctx != hctx) {
> @@ -108,8 +107,7 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list)
> list_splice_tail_init(rq_list, &hctx_list);
>
> dispatch:
> - ret = blk_mq_dispatch_rq_list(hctx, &hctx_list, count);
> - return ret;
> + return blk_mq_dispatch_rq_list(hctx, &hctx_list, count);
> }
>
> #define BLK_MQ_BUDGET_DELAY 3 /* ms units */
> --
> 2.17.1

2020-07-10 09:46:40

by Ming Lei

Subject: Re: [PATCH] blk-mq: Remove unnecessary local variable

On Fri, Jul 10, 2020 at 04:22:10PM +0800, Baolin Wang wrote:
> Hi,
>
> On Sat, Jul 04, 2020 at 03:26:14PM +0800, Baolin Wang wrote:
> > Remove unnecessary local variable 'ret' in blk_mq_dispatch_hctx_list().
> >
>
> A gentle ping?

Reviewed-by: Ming Lei <[email protected]>

--
Ming

2020-07-10 14:02:22

by Jens Axboe

Subject: Re: [PATCH] blk-mq: Remove unnecessary local variable

On 7/4/20 1:26 AM, Baolin Wang wrote:
> Remove unnecessary local variable 'ret' in blk_mq_dispatch_hctx_list().

Applied, thanks.

--
Jens Axboe