2006-05-01 21:02:10

by Petri T. Koistinen

Subject: [PATCH] fs/eventpoll.c: initialize variable, remove warning

From: Petri T. Koistinen <[email protected]>

Remove compiler warning by initializing uninitialized variable.

Signed-off-by: Petri T. Koistinen <[email protected]>
---
fs/eventpoll.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index 1b4491c..243c254 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -497,7 +497,7 @@ void eventpoll_release_file(struct file
*/
asmlinkage long sys_epoll_create(int size)
{
- int error, fd;
+ int error, fd = 0;
struct eventpoll *ep;
struct inode *inode;
struct file *file;

2006-05-02 00:23:49

by Al Viro

Subject: Re: [PATCH] fs/eventpoll.c: initialize variable, remove warning

On Tue, May 02, 2006 at 12:01:51AM +0300, Petri T. Koistinen wrote:
> From: Petri T. Koistinen <[email protected]>
>
> Remove compiler warning by initializing uninitialized variable.

NAK, fd is initialized by ep_getfd() in all cases when it returns 0.
In case if ep_getfd() returns non-zero, fd is never used.