2020-07-09 05:55:02

by Xu Wang

Subject: [PATCH] bcache: writeback: Remove unneeded variable i

Remove unneeded variable i in bch_dirty_init_thread().

Signed-off-by: Xu Wang <[email protected]>
---
drivers/md/bcache/writeback.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index 1cf1e5016cb9..71801c086b82 100644
--- a/drivers/md/bcache/writeback.c
+++ b/drivers/md/bcache/writeback.c
@@ -825,10 +825,8 @@ static int bch_dirty_init_thread(void *arg)
struct btree_iter iter;
struct bkey *k, *p;
int cur_idx, prev_idx, skip_nr;
- int i;

k = p = NULL;
- i = 0;
cur_idx = prev_idx = 0;

bch_btree_iter_init(&c->root->keys, &iter, NULL);
--
2.17.1

2020-07-09 06:07:36

by Coly Li

Subject: Re: [PATCH] bcache: writeback: Remove unneeded variable i

On 2020/7/9 13:53, Xu Wang wrote:
> Remove unneeded variable i in bch_dirty_init_thread().
>
> Signed-off-by: Xu Wang <[email protected]>

Add it into my testing queue. Thanks.

Coly Li

> ---
> drivers/md/bcache/writeback.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
> index 1cf1e5016cb9..71801c086b82 100644
> --- a/drivers/md/bcache/writeback.c
> +++ b/drivers/md/bcache/writeback.c
> @@ -825,10 +825,8 @@ static int bch_dirty_init_thread(void *arg)
> struct btree_iter iter;
> struct bkey *k, *p;
> int cur_idx, prev_idx, skip_nr;
> - int i;
>
> k = p = NULL;
> - i = 0;
> cur_idx = prev_idx = 0;
>
> bch_btree_iter_init(&c->root->keys, &iter, NULL);
>