2020-07-16 08:56:13

by Qinglang Miao

[permalink] [raw]

Subject: [PATCH -next] power: Convert to DEFINE_SHOW_ATTRIBUTE

---

From: Yongqiang Liu <[email protected]>

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yongqiang Liu <[email protected]>
---
drivers/power/supply/da9030_battery.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/power/supply/da9030_battery.c b/drivers/power/supply/da9030_battery.c
index 292ecf875..0deba48d2 100644
--- a/drivers/power/supply/da9030_battery.c
+++ b/drivers/power/supply/da9030_battery.c
@@ -172,17 +172,7 @@ static int bat_debug_show(struct seq_file *s, void *data)
return 0;
}

-static int debug_open(struct inode *inode, struct file *file)
-{
- return single_open(file, bat_debug_show, inode->i_private);
-}
-
-static const struct file_operations bat_debug_fops = {
- .open = debug_open,
- .read_iter = seq_read_iter,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(bat_debug);

static struct dentry *da9030_bat_create_debugfs(struct da9030_charger *charger)
{
--
2.17.1

2020-07-26 22:12:30

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH -next] power: Convert to DEFINE_SHOW_ATTRIBUTE

---

Hi,

On Thu, Jul 16, 2020 at 04:58:49PM +0800, Qinglang Miao wrote:
> From: Yongqiang Liu <[email protected]>
>
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yongqiang Liu <[email protected]>

Thanks, queued.

-- Sebastian

> drivers/power/supply/da9030_battery.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/power/supply/da9030_battery.c b/drivers/power/supply/da9030_battery.c
> index 292ecf875..0deba48d2 100644
> --- a/drivers/power/supply/da9030_battery.c
> +++ b/drivers/power/supply/da9030_battery.c
> @@ -172,17 +172,7 @@ static int bat_debug_show(struct seq_file *s, void *data)
> return 0;
> }
>
> -static int debug_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, bat_debug_show, inode->i_private);
> -}
> -
> -static const struct file_operations bat_debug_fops = {
> - .open = debug_open,
> - .read_iter = seq_read_iter,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(bat_debug);
>
> static struct dentry *da9030_bat_create_debugfs(struct da9030_charger *charger)
> {
> --
> 2.17.1
>

---

Attachments:

(No filename) (1.19 kB)
signature.asc (849.00 B)
Download all attachments