2020-07-20 00:15:06

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] jfs: delete duplicated words in header files

Drop the repeated words "allocation" and "if" in comments.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Dave Kleikamp <[email protected]>
Cc: [email protected]
---
fs/jfs/jfs_extent.h | 2 +-
fs/jfs/jfs_logmgr.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20200717.orig/fs/jfs/jfs_extent.h
+++ linux-next-20200717/fs/jfs/jfs_extent.h
@@ -5,7 +5,7 @@
#ifndef _H_JFS_EXTENT
#define _H_JFS_EXTENT

-/* get block allocation allocation hint as location of disk inode */
+/* get block allocation hint as location of disk inode */
#define INOHINT(ip) \
(addressPXD(&(JFS_IP(ip)->ixpxd)) + lengthPXD(&(JFS_IP(ip)->ixpxd)) - 1)

--- linux-next-20200717.orig/fs/jfs/jfs_logmgr.h
+++ linux-next-20200717/fs/jfs/jfs_logmgr.h
@@ -132,7 +132,7 @@ struct logpage {
* (this comment should be rewritten !)
* jfs uses only "after" log records (only a single writer is allowed
* in a page, pages are written to temporary paging space if
- * if they must be written to disk before commit, and i/o is
+ * they must be written to disk before commit, and i/o is
* scheduled for modified pages to their home location after
* the log records containing the after values and the commit
* record is written to the log on disk, undo discards the copy


2020-10-14 09:23:23

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] jfs: delete duplicated words in header files

ping.

On 7/19/20 5:13 PM, Randy Dunlap wrote:
> Drop the repeated words "allocation" and "if" in comments.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Dave Kleikamp <[email protected]>
> Cc: [email protected]
> ---
> fs/jfs/jfs_extent.h | 2 +-
> fs/jfs/jfs_logmgr.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20200717.orig/fs/jfs/jfs_extent.h
> +++ linux-next-20200717/fs/jfs/jfs_extent.h
> @@ -5,7 +5,7 @@
> #ifndef _H_JFS_EXTENT
> #define _H_JFS_EXTENT
>
> -/* get block allocation allocation hint as location of disk inode */
> +/* get block allocation hint as location of disk inode */
> #define INOHINT(ip) \
> (addressPXD(&(JFS_IP(ip)->ixpxd)) + lengthPXD(&(JFS_IP(ip)->ixpxd)) - 1)
>
> --- linux-next-20200717.orig/fs/jfs/jfs_logmgr.h
> +++ linux-next-20200717/fs/jfs/jfs_logmgr.h
> @@ -132,7 +132,7 @@ struct logpage {
> * (this comment should be rewritten !)
> * jfs uses only "after" log records (only a single writer is allowed
> * in a page, pages are written to temporary paging space if
> - * if they must be written to disk before commit, and i/o is
> + * they must be written to disk before commit, and i/o is
> * scheduled for modified pages to their home location after
> * the log records containing the after values and the commit
> * record is written to the log on disk, undo discards the copy
>


--
~Randy

2020-10-14 23:03:30

by Dave Kleikamp

[permalink] [raw]
Subject: Re: [PATCH] jfs: delete duplicated words in header files

Sorry. I've neglected JFS lately. I'll review and merge these today or
tomorrow, along with some others in my queue.

Shaggy

On 10/14/20 12:29 AM, Randy Dunlap wrote:
> ping.
>
> On 7/19/20 5:13 PM, Randy Dunlap wrote:
>> Drop the repeated words "allocation" and "if" in comments.
>>
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: Dave Kleikamp <[email protected]>
>> Cc: [email protected]
>> ---
>> fs/jfs/jfs_extent.h | 2 +-
>> fs/jfs/jfs_logmgr.h | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> --- linux-next-20200717.orig/fs/jfs/jfs_extent.h
>> +++ linux-next-20200717/fs/jfs/jfs_extent.h
>> @@ -5,7 +5,7 @@
>> #ifndef _H_JFS_EXTENT
>> #define _H_JFS_EXTENT
>>
>> -/* get block allocation allocation hint as location of disk inode */
>> +/* get block allocation hint as location of disk inode */
>> #define INOHINT(ip) \
>> (addressPXD(&(JFS_IP(ip)->ixpxd)) + lengthPXD(&(JFS_IP(ip)->ixpxd)) - 1)
>>
>> --- linux-next-20200717.orig/fs/jfs/jfs_logmgr.h
>> +++ linux-next-20200717/fs/jfs/jfs_logmgr.h
>> @@ -132,7 +132,7 @@ struct logpage {
>> * (this comment should be rewritten !)
>> * jfs uses only "after" log records (only a single writer is allowed
>> * in a page, pages are written to temporary paging space if
>> - * if they must be written to disk before commit, and i/o is
>> + * they must be written to disk before commit, and i/o is
>> * scheduled for modified pages to their home location after
>> * the log records containing the after values and the commit
>> * record is written to the log on disk, undo discards the copy
>>
>
>