2020-07-21 02:50:40

by Max Filippov

Subject: [PATCH] xtensa: fix closing endif comment

Commit 8f74afa22d9b ("xtensa: switch to generic version of pte
allocation") introduced the following build warning for xtensa
arch/xtensa/include/asm/pgalloc.h:67:8: warning: extra tokens at end of
#endif directive [-Wendif-labels]
Fix #endif comment.

Cc: Mike Rapoport <[email protected]>
Fixes: 8f74afa22d9b ("xtensa: switch to generic version of pte allocation")
Signed-off-by: Max Filippov <[email protected]>
---
arch/xtensa/include/asm/pgalloc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h
index 699a8fdf9005..d3a22da4d2c9 100644
--- a/arch/xtensa/include/asm/pgalloc.h
+++ b/arch/xtensa/include/asm/pgalloc.h
@@ -64,6 +64,6 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)
}

#define pmd_pgtable(pmd) pmd_page(pmd)
-#endif CONFIG_MMU
+#endif /* CONFIG_MMU */

#endif /* _XTENSA_PGALLOC_H */
--
2.20.1

2020-07-21 10:24:57

by Mike Rapoport

Subject: Re: [PATCH] xtensa: fix closing endif comment

On Mon, Jul 20, 2020 at 07:47:51PM -0700, Max Filippov wrote:
> Commit 8f74afa22d9b ("xtensa: switch to generic version of pte
> allocation") introduced the following build warning for xtensa
> arch/xtensa/include/asm/pgalloc.h:67:8: warning: extra tokens at end of
> #endif directive [-Wendif-labels]
> Fix #endif comment.

Oops :)

> Cc: Mike Rapoport <[email protected]>
> Fixes: 8f74afa22d9b ("xtensa: switch to generic version of pte allocation")
> Signed-off-by: Max Filippov <[email protected]>

Reviewed-by: Mike Rapoport <[email protected]>

> ---
> arch/xtensa/include/asm/pgalloc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h
> index 699a8fdf9005..d3a22da4d2c9 100644
> --- a/arch/xtensa/include/asm/pgalloc.h
> +++ b/arch/xtensa/include/asm/pgalloc.h
> @@ -64,6 +64,6 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)
> }
>
> #define pmd_pgtable(pmd) pmd_page(pmd)
> -#endif CONFIG_MMU
> +#endif /* CONFIG_MMU */
>
> #endif /* _XTENSA_PGALLOC_H */
> --
> 2.20.1
>

--
Sincerely yours,
Mike.