2006-05-09 20:27:08

by Chris Wright

[permalink] [raw]
Subject: [PATCH resend] smbfs chroot issue (CVE-2006-1864)

From: Olaf Kirch <[email protected]>

Mark Moseley reported that a chroot environment on a SMB share can be
left via "cd ..\\". Similar to CVE-2006-1863 issue with cifs, this fix
is for smbfs.

Steven French <[email protected]> wrote:

Looks fine to me. This should catch the slash on lookup or equivalent,
which will be all obvious paths of interest.

Signed-off-by: Chris Wright <[email protected]>
---
This fix is in -stable, but doesn't appear to be in your tree yet.

fs/smbfs/dir.c | 5 +++++
1 file changed, 5 insertions(+)

--- linus-2.6.orig/fs/smbfs/dir.c
+++ linus-2.6/fs/smbfs/dir.c
@@ -434,6 +434,11 @@ smb_lookup(struct inode *dir, struct den
if (dentry->d_name.len > SMB_MAXNAMELEN)
goto out;

+ /* Do not allow lookup of names with backslashes in */
+ error = -EINVAL;
+ if (memchr(dentry->d_name.name, '\\', dentry->d_name.len))
+ goto out;
+
lock_kernel();
error = smb_proc_getattr(dentry, &finfo);
#ifdef SMBFS_PARANOIA

_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable