2020-07-29 00:48:47

by Bjorn Andersson

Subject: [PATCH] dt-bindings: hwlock: qcom: Remove invalid binding

The Qualcomm hwlock is described in DeviceTree either directly on the
mmio bus or split between a syscon and a mutex node, but as noted in
[1] the latter is not valid DT, so remove any traces of this from the
binding.

[1] https://lore.kernel.org/r/CAL_JsqLa9GBtbgN6aL7AQ=A6V-YRtPgYqh6XgM2kpx532+r4Gg@mail.gmail.com/

Signed-off-by: Bjorn Andersson <[email protected]>
---
.../bindings/hwlock/qcom-hwspinlock.yaml | 25 +------------------
1 file changed, 1 insertion(+), 24 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
index 88f975837588..1c7149f7d171 100644
--- a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
+++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
@@ -25,37 +25,14 @@ properties:
'#hwlock-cells':
const: 1

- syscon:
- $ref: "/schemas/types.yaml#/definitions/phandle-array"
- description:
- Should be a triple of phandle referencing the TCSR mutex syscon, offset
- of first mutex within the syscon and stride between each mutex.
-
required:
- compatible
+ - reg
- '#hwlock-cells'

-oneOf:
- - required:
- - reg
- - required:
- - syscon
-
additionalProperties: false

examples:
- - |
- tcsr_mutex_block: syscon@fd484000 {
- compatible = "syscon";
- reg = <0xfd484000 0x2000>;
- };
-
- hwlock {
- compatible = "qcom,tcsr-mutex";
- syscon = <&tcsr_mutex_block 0 0x80>;
-
- #hwlock-cells = <1>;
- };
- |
tcsr_mutex: hwlock@1f40000 {
compatible = "qcom,tcsr-mutex";
--
2.26.2

2020-07-31 17:57:22

by Rob Herring

Subject: Re: [PATCH] dt-bindings: hwlock: qcom: Remove invalid binding

On Tue, Jul 28, 2020 at 6:48 PM Bjorn Andersson
<[email protected]> wrote:
>
> The Qualcomm hwlock is described in DeviceTree either directly on the
> mmio bus or split between a syscon and a mutex node, but as noted in
> [1] the latter is not valid DT, so remove any traces of this from the
> binding.
>
> [1] https://lore.kernel.org/r/CAL_JsqLa9GBtbgN6aL7AQ=A6V-YRtPgYqh6XgM2kpx532+r4Gg@mail.gmail.com/
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> .../bindings/hwlock/qcom-hwspinlock.yaml | 25 +------------------
> 1 file changed, 1 insertion(+), 24 deletions(-)

Reviewed-by: Rob Herring <[email protected]>