2020-08-19 12:37:34

by Geert Uytterhoeven

Subject: [PATCH v3] block: Make request_queue.rpm_status an enum

request_queue.rpm_status is assigned values of the rpm_status enum only,
so reflect that in its type.

Note that including <linux/pm.h> is (currently) a no-op, as it is
already included through <linux/genhd.h> and <linux/device.h>, but it is
better to play it safe.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Acked-by: Rafael J. Wysocki <[email protected]>
---
v3:
- #include <linux/pm.h>, as requested by Bart,

v2:
- Add Acked-by.
---
include/linux/blkdev.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index bb5636cc17b91a75..0a1730b30ad210b4 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -24,6 +24,7 @@
#include <linux/percpu-refcount.h>
#include <linux/scatterlist.h>
#include <linux/blkzoned.h>
+#include <linux/pm.h>

struct module;
struct scsi_ioctl_command;
@@ -458,7 +459,7 @@ struct request_queue {

#ifdef CONFIG_PM
struct device *dev;
- int rpm_status;
+ enum rpm_status rpm_status;
unsigned int nr_pending;
#endif

--
2.17.1

2020-08-19 12:58:12

by Jens Axboe

Subject: Re: [PATCH v3] block: Make request_queue.rpm_status an enum

On 8/19/20 5:34 AM, Geert Uytterhoeven wrote:
> request_queue.rpm_status is assigned values of the rpm_status enum only,
> so reflect that in its type.
>
> Note that including <linux/pm.h> is (currently) a no-op, as it is
> already included through <linux/genhd.h> and <linux/device.h>, but it is
> better to play it safe.

Applied, thanks.

--
Jens Axboe