2020-08-31 07:15:59

by Dillon Min

Subject: [PATCH: 0/2] Fix TC35894 gpio interrupt bug

From: dillon min <[email protected]>

This patchset intend to fix two bug on tc35894

1 offset counting is wrong in tc3589x_gpio_irq_sync_unlock()
2 disable Direct KBD interrupts in gpio-tc3589x's probe(),
at least have to do this on tc35894, if not, after chip reset,
IRQST(0x91) will always be 0x20, IRQN always low level,
can't be cleared. need more test on other tc3589x.

dillon min (2):
gpio: tc35894: fix up tc35894 interrupt configuration
gpio: tc35894: Disable Direct KBD interrupts to enable gpio irq

drivers/gpio/gpio-tc3589x.c | 12 +++++++++++-
include/linux/mfd/tc3589x.h | 5 +++++
2 files changed, 16 insertions(+), 1 deletion(-)

--
2.7.4

2020-08-31 07:16:01

by Dillon Min

Subject: [PATCH: 2/2] gpio: tc35894: Disable Direct KBD interrupts to enable gpio irq

From: dillon min <[email protected]>

On tc35894, have to disable direct keypad interrupts to make
it as general purpose interrupts functionality work.
if not, after chip reset, IRQST(0x91) will always 0x20,
IRQN always low level, can't be clear.

verified on tc35894, need more test on other tc3589x.

Signed-off-by: dillon min <[email protected]>
---
drivers/gpio/gpio-tc3589x.c | 10 ++++++++++
include/linux/mfd/tc3589x.h | 5 +++++
2 files changed, 15 insertions(+)

diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index ea3f68a28fea..760e716468dc 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio-tc3589x.c
@@ -334,6 +334,16 @@ static int tc3589x_gpio_probe(struct platform_device *pdev)
if (ret < 0)
return ret;

+ /* For tc35894, have to disable Direct KBD interrupts,
+ * else IRQST will always be 0x20, IRQN low level, can't
+ * clear the irq status.
+ * TODO: need more test on other tc3589x chip.
+ */
+ ret = tc3589x_reg_write(tc3589x, TC3589x_DKBDMSK,
+ TC3589x_DKBDMSK_ELINT | TC3589x_DKBDMSK_EINT);
+ if (ret < 0)
+ return ret;
+
ret = devm_request_threaded_irq(&pdev->dev,
irq, NULL, tc3589x_gpio_irq,
IRQF_ONESHOT, "tc3589x-gpio",
diff --git a/include/linux/mfd/tc3589x.h b/include/linux/mfd/tc3589x.h
index bb2b19599761..c18fc7c3c2d6 100644
--- a/include/linux/mfd/tc3589x.h
+++ b/include/linux/mfd/tc3589x.h
@@ -19,6 +19,9 @@ enum tx3589x_block {
#define TC3589x_RSTCTRL_KBDRST (1 << 1)
#define TC3589x_RSTCTRL_GPIRST (1 << 0)

+#define TC3589x_DKBDMSK_ELINT (1 << 1)
+#define TC3589x_DKBDMSK_EINT (1 << 0)
+
/* Keyboard Configuration Registers */
#define TC3589x_KBDSETTLE_REG 0x01
#define TC3589x_KBDBOUNCE 0x02
@@ -101,6 +104,8 @@ enum tx3589x_block {
#define TC3589x_GPIOODM2 0xE4
#define TC3589x_GPIOODE2 0xE5

+#define TC3589x_DKBDMSK 0xF3
+
#define TC3589x_INT_GPIIRQ 0
#define TC3589x_INT_TI0IRQ 1
#define TC3589x_INT_TI1IRQ 2
--
2.7.4